mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2024-11-22 00:37:36 -06:00
e9af0c3226
Restructured these modules for ease of maintenance and apply the single responsibility principle (wherever applicable). * SchemaView - Split the code based on the functionality and responsibility. - Introduced a new View 'InlineView' instead of using the 'nextInline' configuration of the fields to have a better, and manageable view. - Using the separate class 'SchemaState' for managing the data and states of the SchemaView (separated from the 'useSchemaState' custom hook). - Introduced three new custom hooks 'useFieldValue', 'useFieldOptions', 'useFieldError' for the individual control to use for each Schema Field. - Don't pass value as the parameter props, and let the 'useFieldValue' and other custom hooks to decide, whether to rerender the control itself or the whole dialog/view. (single responsibility principle) - Introduced a new data store with a subscription facility. - Moving the field metadata (option) evaluation to a separate place for better management, and each option can be defined for a particular kind of field (for example - collection, row, cell, general, etc). - Allow to provide custom control for all kind of Schema field. * DataGridView - Same as SchemaView, split the DataGridView call into smaller, manageable chunks. (For example - grid, row, mappedCell, etc). - Use context based approach for providing the row and table data instead of passing them as parameters to every component separately. - Have a facility to extend this feature separately in future. (for example - selectable cell, column grouping, etc.) - Separated the features like deletable, editable, reorder, expandable etc. cells using the above feature support. - Added ability to provide the CustomHeader, and CustomRow through the Schema field, which will extend the ability to customize better. - Removed the 'DataGridViewWithHeaderForm' as it has been achieved through providing 'CustomHeader', and also introduced 'DataGridFormHeader' (a custom header) to achieve the same feature as 'DataGridViewWithHeaderForm'.
107 lines
3.4 KiB
JavaScript
107 lines
3.4 KiB
JavaScript
/////////////////////////////////////////////////////////////
|
|
//
|
|
// pgAdmin 4 - PostgreSQL Tools
|
|
//
|
|
// Copyright (C) 2013 - 2024, The pgAdmin Development Team
|
|
// This software is released under the PostgreSQL Licence
|
|
//
|
|
//////////////////////////////////////////////////////////////
|
|
|
|
|
|
import PgaJobStepSchema from '../../../pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui';
|
|
import {genericBeforeEach, getCreateView, getEditView, getPropertiesView} from '../genericFunctions';
|
|
|
|
describe('PgaJobStepSchema', ()=>{
|
|
|
|
let schemaObj;
|
|
let getInitData = ()=>Promise.resolve({});
|
|
|
|
beforeEach(()=>{
|
|
schemaObj = new PgaJobStepSchema(
|
|
{ databases: ()=>[] }, [], { jstdbname: 'postgres' }
|
|
);
|
|
genericBeforeEach();
|
|
});
|
|
|
|
it('create', async ()=>{
|
|
await getCreateView(schemaObj);
|
|
});
|
|
|
|
it('edit', async ()=>{
|
|
await getEditView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('properties', async ()=>{
|
|
await getPropertiesView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('validate', ()=>{
|
|
let state = {};
|
|
let setError = jest.fn();
|
|
|
|
state.name = 'my_step';
|
|
state.jstkind = true;
|
|
state.jstconntype = true;
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstdbname', 'Please select a database.');
|
|
|
|
state.jstdbname = 'postgres';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstdbname', null);
|
|
|
|
state.jstconntype = false;
|
|
state.jstconnstr = null;
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', 'Please enter a connection string.');
|
|
|
|
state.jstconnstr = '**!!';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', 'Please enter a valid connection string.');
|
|
|
|
state.jstconnstr = 'host:\'192.168.1.7\'';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', 'Please enter a valid connection string.');
|
|
|
|
state.jstconnstr = 'host:\'192.168.1.7\'';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', 'Please enter a valid connection string.');
|
|
|
|
state.jstconnstr = 'hostaddrtest=\'192.168.1.7\'';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', 'Invalid parameter in the connection string - hostaddrtest.');
|
|
|
|
state.jstconnstr = 'host=\'192.168.1.7\' port=5432';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstconnstr', null);
|
|
|
|
state.jstcode = null;
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstcode', 'Please specify code to execute.');
|
|
|
|
state.jstcode = 'PERFORM 1;';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstcode', null);
|
|
|
|
state.jstonerror = null;
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstonerror', 'Please select valid on error option.');
|
|
|
|
state.jstonerror = 'f';
|
|
setError.mockClear();
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('jstonerror', null);
|
|
});
|
|
});
|
|
|