mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2026-08-17 16:34:44 -05:00
Ashesh Vashi
0296de48ee
pgadmin4-appbundle-build #110 (macos-x64) failed with: error: otool-classic: can't open file: ./Contents/Frameworks/pgAdmin error: otool-classic: can't open file: ./Contents/Frameworks/Electron _fixup_imports built its worklist with `awk -F':| '`, a regex alternation that splits on a literal ':' OR any bare space. `file`'s actual output format is "path: description" (colon-space as one token), so any space *inside* the path itself - "pgAdmin 4 Helper (Plugin).app", "Electron Framework.framework", both routine in macOS app bundles - also got treated as a split point, truncating $1 to whatever preceded the first space. The resulting list was then joined with a single space (ORS=" ") and iterated via an unquoted `for x in $list`, which word-splits on spaces again - doubly ambiguous between a path's own spaces and the list's separator, unrecoverable however it's parsed. Fix: split only on the literal ": " token file emits (`awk -F': '`, not `-F ':| '`), and switch the whole worklist to newline-separated instead of space-separated, iterated with `while IFS= read -r` instead of `for x in $unquoted_list`, at both the outer (executable) level and inner (library-copy) level (`TODO="${TODO}"$'\n'"..."`). Not yet verified against a real buildfarm run - can't reproduce the macOS codesigning environment locally. Watching the next pgadmin4-appbundle-build run.