mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2024-11-22 08:46:39 -06:00
862f101772
1. Replace the current layout library wcDocker with ReactJS based rc-dock. #6479 2. Have close buttons on individual panel tabs instead of common. #2821 3. Changes in the context menu on panel tabs - Add close, close all and close others menu items. #5394 4. Allow closing all the tabs, including SQL and Properties. #4733 5. Changes in docking behaviour of different tabs based on user requests and remove lock layout menu. 6. Fix an issue where the scroll position of panels was not remembered on Firefox. #2986 7. Reset layout now will not require page refresh and is done spontaneously. 8. Use the zustand store for storing preferences instead of plain JS objects. This will help reflecting preferences immediately. 9. The above fix incorrect format (no indent) of SQL stored functions/procedures. #6720 10. New version check is moved to an async request now instead of app start to improve startup performance. 11. Remove jQuery and Bootstrap completely. 12. Replace jasmine and karma test runner with jest. Migrate all the JS test cases to jest. This will save time in writing and debugging JS tests. 13. Other important code improvements and cleanup.
315 lines
9.3 KiB
JavaScript
315 lines
9.3 KiB
JavaScript
/////////////////////////////////////////////////////////////
|
|
//
|
|
// pgAdmin 4 - PostgreSQL Tools
|
|
//
|
|
// Copyright (C) 2013 - 2023, The pgAdmin Development Team
|
|
// This software is released under the PostgreSQL Licence
|
|
//
|
|
//////////////////////////////////////////////////////////////
|
|
|
|
|
|
import { SCHEMA_STATE_ACTIONS } from '../../../pgadmin/static/js/SchemaView';
|
|
import _ from 'lodash';
|
|
import { getNodeTableSchema, LikeSchema } from '../../../pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.ui';
|
|
import * as nodeAjax from '../../../pgadmin/browser/static/js/node_ajax';
|
|
import {genericBeforeEach, getCreateView, getEditView, getPropertiesView} from '../genericFunctions';
|
|
import pgAdmin from '../fake_pgadmin';
|
|
|
|
function getFieldDepChange(schema, id) {
|
|
return _.find(schema.fields, (f)=>f.id==id)?.depChange;
|
|
}
|
|
|
|
describe('TableSchema', ()=>{
|
|
|
|
let schemaObj;
|
|
let getInitData = ()=>Promise.resolve({});
|
|
|
|
beforeAll(()=>{
|
|
jest.spyOn(nodeAjax, 'getNodeAjaxOptions').mockReturnValue(Promise.resolve([]));
|
|
jest.spyOn(nodeAjax, 'getNodeListByName').mockReturnValue(Promise.resolve([]));
|
|
schemaObj = getNodeTableSchema({
|
|
server: {
|
|
_id: 1,
|
|
},
|
|
schema: {
|
|
_label: 'public',
|
|
}
|
|
}, {}, {
|
|
Nodes: {table: {}},
|
|
serverInfo: {
|
|
1: {
|
|
user: {
|
|
name: 'Postgres',
|
|
}
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
|
|
|
|
beforeEach(()=>{
|
|
genericBeforeEach();
|
|
});
|
|
|
|
it('create', async ()=>{
|
|
await getCreateView(schemaObj);
|
|
});
|
|
|
|
it('edit', async ()=>{
|
|
await getEditView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('properties', async ()=>{
|
|
await getPropertiesView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('getTableOid', ()=>{
|
|
schemaObj.inheritedTableList = [
|
|
{label: 'tab1', tid: 140391},
|
|
{label: 'tab2', tid: 180191}
|
|
];
|
|
expect(schemaObj.getTableOid('tab2')).toBe(180191);
|
|
});
|
|
|
|
it('canEditDeleteRowColumns', ()=>{
|
|
expect(schemaObj.canEditDeleteRowColumns({inheritedfrom: 1234})).toBe(false);
|
|
expect(schemaObj.canEditDeleteRowColumns({inheritedfrom: null})).toBe(true);
|
|
});
|
|
|
|
it('LikeSchema typname change', ()=>{
|
|
let likeSchemaObj = new LikeSchema([]);
|
|
/* Dummy */
|
|
likeSchemaObj.top = new LikeSchema([]);
|
|
let depResp = getFieldDepChange(likeSchemaObj, 'like_relation')({typname: 'type1'}, ['typname']);
|
|
expect(depResp).toEqual({
|
|
like_relation: null,
|
|
like_default_value: false,
|
|
like_constraints: false,
|
|
like_indexes: false,
|
|
like_storage: false,
|
|
like_comments: false,
|
|
like_compression: false,
|
|
like_generated: false,
|
|
like_identity: false,
|
|
like_statistics: false
|
|
});
|
|
});
|
|
|
|
describe('typname change', ()=>{
|
|
let confirmSpy;
|
|
let deferredDepChange;
|
|
let oftypeColumns = [
|
|
{name: 'id'}
|
|
];
|
|
beforeEach(()=>{
|
|
jest.spyOn(schemaObj, 'changeColumnOptions');
|
|
jest.spyOn(schemaObj, 'getTableOid').mockReturnValue(140391);
|
|
confirmSpy = jest.spyOn(pgAdmin.Browser.notifier, 'confirm');
|
|
deferredDepChange = _.find(schemaObj.fields, (f)=>f.id=='typname')?.deferredDepChange;
|
|
schemaObj.ofTypeTables = [
|
|
{label: 'type1', oftype_columns: oftypeColumns}
|
|
];
|
|
});
|
|
|
|
let onDepChangeAction = (depChange, done)=> {
|
|
expect(depChange()).toEqual({
|
|
columns: oftypeColumns,
|
|
primary_key: [],
|
|
foreign_key: [],
|
|
exclude_constraint: [],
|
|
unique_constraint: [],
|
|
partition_keys: [],
|
|
partitions: [],
|
|
});
|
|
expect(schemaObj.changeColumnOptions).toHaveBeenCalledWith(oftypeColumns);
|
|
done();
|
|
};
|
|
|
|
it('initial selection with OK', (done)=>{
|
|
let state = {typname: 'type1'};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
typname: null,
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
onDepChangeAction(depChange, done);
|
|
});
|
|
/* Press OK */
|
|
confirmSpy.mock.calls[0][2]();
|
|
});
|
|
|
|
it('initial selection with Cancel', (done)=>{
|
|
confirmSpy.mockClear();
|
|
let state = {typname: 'type1'};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
typname: null,
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
expect(depChange()).toEqual({
|
|
typname: null,
|
|
});
|
|
done();
|
|
});
|
|
/* Press Cancel */
|
|
confirmSpy.mock.calls[0][3]();
|
|
});
|
|
|
|
it('later selection', (done)=>{
|
|
let state = {typname: 'type1'};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
typname: 'typeold',
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
onDepChangeAction(depChange, done);
|
|
});
|
|
});
|
|
|
|
it('empty', (done)=>{
|
|
let state = {typname: null};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
typname: null,
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
expect(depChange()).toBeUndefined();
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('coll_inherits change', ()=>{
|
|
let deferredDepChange;
|
|
let inheritCol = {name: 'id'};
|
|
let onRemoveAction = (depChange, state, done)=> {
|
|
let finalCols = [{name: 'desc'}];
|
|
expect(depChange(state)).toEqual({
|
|
adding_inherit_cols: false,
|
|
columns: finalCols,
|
|
});
|
|
expect(schemaObj.changeColumnOptions).toHaveBeenCalledWith(finalCols);
|
|
done();
|
|
};
|
|
|
|
beforeEach(()=>{
|
|
jest.spyOn(schemaObj, 'changeColumnOptions');
|
|
jest.spyOn(schemaObj, 'getTableOid').mockReturnValue(140391);
|
|
jest.spyOn(schemaObj, 'getColumns').mockReturnValue(Promise.resolve([inheritCol]));
|
|
deferredDepChange = _.find(schemaObj.fields, (f)=>f.id=='coll_inherits')?.deferredDepChange;
|
|
});
|
|
|
|
it('add first selection', (done)=>{
|
|
let state = {columns: [], coll_inherits: ['table1']};
|
|
let newCol = schemaObj.columnsSchema.getNewData(inheritCol);
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
coll_inherits: [],
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
let finalCols = [newCol];
|
|
expect(depChange(state)).toEqual({
|
|
adding_inherit_cols: false,
|
|
columns: finalCols,
|
|
});
|
|
expect(schemaObj.changeColumnOptions).toHaveBeenCalledWith(finalCols);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('add more', (done)=>{
|
|
let newCol = schemaObj.columnsSchema.getNewData(inheritCol);
|
|
let state = {columns: [newCol], coll_inherits: ['table1', 'table2']};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
coll_inherits: ['table1'],
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
let finalCols = [newCol];
|
|
expect(depChange(state)).toEqual({
|
|
adding_inherit_cols: false,
|
|
columns: [newCol],
|
|
});
|
|
expect(schemaObj.changeColumnOptions).toHaveBeenCalledWith(finalCols);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('remove one table', (done)=>{
|
|
inheritCol.inheritedid = 140391;
|
|
let newCol = schemaObj.columnsSchema.getNewData(inheritCol);
|
|
let state = {columns: [{name: 'desc'}, newCol], coll_inherits: ['table1']};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
coll_inherits: ['table1', 'table2'],
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
onRemoveAction(depChange, state, done);
|
|
});
|
|
});
|
|
|
|
it('remove all', (done)=>{
|
|
inheritCol.inheritedid = 140391;
|
|
let newCol = schemaObj.columnsSchema.getNewData(inheritCol);
|
|
let state = {columns: [{name: 'desc'}, newCol], coll_inherits: []};
|
|
let deferredPromise = deferredDepChange(state, null, null, {
|
|
oldState: {
|
|
coll_inherits: ['table1'],
|
|
},
|
|
});
|
|
deferredPromise.then((depChange)=>{
|
|
onRemoveAction(depChange, state, done);
|
|
});
|
|
});
|
|
});
|
|
|
|
it('depChange', ()=>{
|
|
jest.spyOn(schemaObj, 'getTableOid').mockReturnValue(140391);
|
|
let state = {};
|
|
|
|
state.is_partitioned = true;
|
|
state.coll_inherits = ['table1'];
|
|
expect(getFieldDepChange(schemaObj, 'coll_inherits')(state, ['is_partitioned'], null, {
|
|
type: SCHEMA_STATE_ACTIONS.SET_VALUE,
|
|
path: ['is_partitioned'],
|
|
})).toEqual({
|
|
coll_inherits: [],
|
|
});
|
|
|
|
jest.spyOn(schemaObj, 'getServerVersion').mockReturnValue(100000);
|
|
schemaObj.constraintsObj.top = schemaObj;
|
|
expect(getFieldDepChange(schemaObj.constraintsObj, 'primary_key')({is_partitioned: true})).toEqual({
|
|
primary_key: []
|
|
});
|
|
expect(getFieldDepChange(schemaObj.constraintsObj, 'foreign_key')({is_partitioned: true})).toEqual({
|
|
foreign_key: []
|
|
});
|
|
expect(getFieldDepChange(schemaObj.constraintsObj, 'unique_constraint')({is_partitioned: true})).toEqual({
|
|
unique_constraint: []
|
|
});
|
|
expect(getFieldDepChange(schemaObj.constraintsObj, 'exclude_constraint')({is_partitioned: true})).toEqual({
|
|
exclude_constraint: []
|
|
});
|
|
});
|
|
|
|
it('validate', ()=>{
|
|
let state = {is_partitioned: true};
|
|
let setError = jest.fn();
|
|
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('partition_keys', 'Please specify at least one key for partitioned table.');
|
|
|
|
state.partition_keys = [{key: 'id'}];
|
|
expect(schemaObj.validate(state, setError)).toBe(false);
|
|
});
|
|
});
|
|
|