mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2025-02-25 18:55:31 -06:00
Changes included: 1. Created function for traversing the browser tree. 2. Fixed some synchronization issues. 3. Modified locators. 4. Test cases fix for the recent commits.
155 lines
5.7 KiB
Python
155 lines
5.7 KiB
Python
##########################################################################
|
|
#
|
|
# pgAdmin 4 - PostgreSQL Tools
|
|
#
|
|
# Copyright (C) 2013 - 2019, The pgAdmin Development Team
|
|
# This software is released under the PostgreSQL Licence
|
|
#
|
|
##########################################################################
|
|
|
|
from __future__ import print_function
|
|
import os
|
|
import sys
|
|
import time
|
|
|
|
from selenium.webdriver.common.keys import Keys
|
|
from selenium.webdriver.support.ui import WebDriverWait
|
|
from selenium.webdriver.common.by import By
|
|
from selenium.common.exceptions import StaleElementReferenceException, \
|
|
TimeoutException
|
|
from regression.feature_utils.base_feature_test import BaseFeatureTest
|
|
from regression.feature_utils.locators import QueryToolLocators
|
|
|
|
|
|
class CheckFileManagerFeatureTest(BaseFeatureTest):
|
|
"""Tests to check file manager for XSS."""
|
|
|
|
scenarios = [
|
|
("File manager feature test",
|
|
dict())
|
|
]
|
|
|
|
def before(self):
|
|
if os.name == 'nt':
|
|
self.skipTest("This test is skipped for Windows. As Windows "
|
|
"does not allow the '<' and '>' character while "
|
|
"specifying the file name.")
|
|
|
|
self.page.add_server(self.server)
|
|
self.wait = WebDriverWait(self.page.driver, 10)
|
|
self.XSS_FILE = '/tmp/<img src=x onmouseover=alert("1")>.sql'
|
|
# Remove any previous file
|
|
if os.path.isfile(self.XSS_FILE):
|
|
os.remove(self.XSS_FILE)
|
|
|
|
def after(self):
|
|
self.page.close_query_tool(False)
|
|
self.page.remove_server(self.server)
|
|
|
|
def runTest(self):
|
|
print("Tests to check if File manager is vulnerable to XSS... ",
|
|
file=sys.stderr, end="")
|
|
self._navigate_to_query_tool()
|
|
self.page.fill_codemirror_area_with("SELECT 1;")
|
|
self._create_new_file()
|
|
self._open_file_manager_and_check_xss_file()
|
|
print("OK.", file=sys.stderr)
|
|
|
|
print("File manager sorting of data", file=sys.stderr)
|
|
self._check_file_sorting()
|
|
print("OK.", file=sys.stderr)
|
|
|
|
def _navigate_to_query_tool(self):
|
|
self.page.expand_database_node(
|
|
self.server['name'],
|
|
self.server['db_password'], self.test_db)
|
|
self.page.open_query_tool()
|
|
|
|
def _create_new_file(self):
|
|
self.page.find_by_css_selector(QueryToolLocators.btn_save_file)\
|
|
.click()
|
|
# Set the XSS value in input
|
|
self.page.find_by_css_selector('.change_file_types')
|
|
self.page.fill_input_by_css_selector(
|
|
QueryToolLocators.input_file_path_css, self.XSS_FILE)
|
|
# Save the file
|
|
self.page.click_modal('Create')
|
|
self.page.wait_for_query_tool_loading_indicator_to_disappear()
|
|
|
|
def _open_file_manager_and_check_xss_file(self):
|
|
load_file = self.page.find_by_css_selector(
|
|
QueryToolLocators.btn_load_file_css)
|
|
load_file.click()
|
|
self.page.find_by_css_selector('.change_file_types')
|
|
self.page.fill_input_by_css_selector(
|
|
QueryToolLocators.input_file_path_css,
|
|
"/tmp/", key_after_input=Keys.RETURN)
|
|
|
|
if self.page.driver.capabilities['browserName'] == 'firefox':
|
|
table = self.page.wait_for_element_to_reload(
|
|
lambda driver: driver.find_element_by_css_selector(
|
|
QueryToolLocators.select_file_content_css)
|
|
)
|
|
else:
|
|
table = self.page.driver.find_element_by_css_selector(
|
|
QueryToolLocators.select_file_content_css)
|
|
retry_count = 0
|
|
while retry_count < 5:
|
|
try:
|
|
contents = table.get_attribute('innerHTML')
|
|
break
|
|
except (StaleElementReferenceException, TimeoutException):
|
|
retry_count += 1
|
|
|
|
self.page.click_modal('Cancel')
|
|
self.page.wait_for_query_tool_loading_indicator_to_disappear()
|
|
self._check_escaped_characters(
|
|
contents,
|
|
'<img src=x onmouseover=alert("1")>.sql',
|
|
'File manager'
|
|
)
|
|
|
|
def _check_escaped_characters(self, source_code, string_to_find, source):
|
|
# For XSS we need to search against element's html code
|
|
assert source_code.find(
|
|
string_to_find
|
|
) != -1, "{0} might be vulnerable to XSS ".format(source)
|
|
|
|
def _check_file_sorting(self):
|
|
load_file = self.page.find_by_css_selector(
|
|
QueryToolLocators.btn_load_file_css)
|
|
load_file.click()
|
|
self.page.find_by_css_selector("#contents th[data-column='0']")
|
|
|
|
# Added time.sleep so that the element to be clicked.
|
|
time.sleep(0.05)
|
|
|
|
# Intermittently facing issue on first click it is not successful
|
|
# so tried couple of times.
|
|
success = self.page.retry_click(
|
|
(By.XPATH,
|
|
"//th[@data-column='0']/div/span[text()='Name']"),
|
|
(By.CSS_SELECTOR,
|
|
"#contents th[data-column='0'].tablesorter-headerAsc"))
|
|
|
|
if not success:
|
|
raise Exception("Unable to sort in ascending order while clicked "
|
|
"on 'Name' column")
|
|
# Added time.sleep so that the element to be clicked.
|
|
time.sleep(0.05)
|
|
|
|
# Click and Check for sort Descending
|
|
# Intermittently facing issue on first click it is not successful
|
|
# so tried couple of times.
|
|
success = self.page.retry_click(
|
|
(By.XPATH,
|
|
"//th[@data-column='0']/div/span[text()='Name']"),
|
|
(By.CSS_SELECTOR,
|
|
"#contents th[data-column='0'].tablesorter-headerDesc"))
|
|
|
|
if not success:
|
|
raise Exception("Unable to sort in descending order while clicked "
|
|
"on 'Name' column")
|
|
|
|
self.page.click_modal('Cancel')
|