mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2024-11-22 08:46:39 -06:00
862f101772
1. Replace the current layout library wcDocker with ReactJS based rc-dock. #6479 2. Have close buttons on individual panel tabs instead of common. #2821 3. Changes in the context menu on panel tabs - Add close, close all and close others menu items. #5394 4. Allow closing all the tabs, including SQL and Properties. #4733 5. Changes in docking behaviour of different tabs based on user requests and remove lock layout menu. 6. Fix an issue where the scroll position of panels was not remembered on Firefox. #2986 7. Reset layout now will not require page refresh and is done spontaneously. 8. Use the zustand store for storing preferences instead of plain JS objects. This will help reflecting preferences immediately. 9. The above fix incorrect format (no indent) of SQL stored functions/procedures. #6720 10. New version check is moved to an async request now instead of app start to improve startup performance. 11. Remove jQuery and Bootstrap completely. 12. Replace jasmine and karma test runner with jest. Migrate all the JS test cases to jest. This will save time in writing and debugging JS tests. 13. Other important code improvements and cleanup.
235 lines
7.0 KiB
JavaScript
235 lines
7.0 KiB
JavaScript
/////////////////////////////////////////////////////////////
|
|
//
|
|
// pgAdmin 4 - PostgreSQL Tools
|
|
//
|
|
// Copyright (C) 2013 - 2023, The pgAdmin Development Team
|
|
// This software is released under the PostgreSQL Licence
|
|
//
|
|
//////////////////////////////////////////////////////////////
|
|
|
|
|
|
import ColumnSchema from '../../../pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.ui';
|
|
import BaseUISchema from '../../../pgadmin/static/js/SchemaView/base_schema.ui';
|
|
import _ from 'lodash';
|
|
import {addNewDatagridRow, genericBeforeEach, getCreateView, getEditView, getPropertiesView} from '../genericFunctions';
|
|
|
|
class MockSchema extends BaseUISchema {
|
|
get baseFields() {
|
|
return [];
|
|
}
|
|
}
|
|
|
|
class ColumnInColl extends BaseUISchema {
|
|
constructor() {
|
|
super();
|
|
}
|
|
|
|
get baseFields() {
|
|
return [{
|
|
id: 'columns', label: '', type: 'collection',
|
|
schema: new ColumnSchema(
|
|
()=>new MockSchema(),
|
|
{},
|
|
()=>Promise.resolve([]),
|
|
()=>Promise.resolve([]),
|
|
),
|
|
editable: false,
|
|
canAdd: true, canEdit: false, canDelete: true, hasRole: true,
|
|
columns : ['name' , 'cltype', 'attlen', 'attprecision', 'attnotnull', 'is_primary_key'],
|
|
}];
|
|
}
|
|
}
|
|
|
|
function getFieldDepChange(schema, id) {
|
|
return _.find(schema.fields, (f)=>f.id==id)?.depChange;
|
|
}
|
|
|
|
describe('ColumnSchema', ()=>{
|
|
|
|
let schemaObj = new ColumnSchema(
|
|
()=>new MockSchema(),
|
|
{},
|
|
()=>Promise.resolve([]),
|
|
()=>Promise.resolve([]),
|
|
);
|
|
let datatypes = [
|
|
{value: 'numeric', length: true, precision: true, min_val: 1, max_val: 140391},
|
|
{value: 'character varying', length: true, precision: false, min_val: 1, max_val: 140391},
|
|
];
|
|
let getInitData = ()=>Promise.resolve({});
|
|
|
|
beforeEach(()=>{
|
|
genericBeforeEach();
|
|
});
|
|
|
|
it('create', async ()=>{
|
|
await getCreateView(schemaObj);
|
|
});
|
|
|
|
it('edit', async ()=>{
|
|
await getEditView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('properties', async ()=>{
|
|
await getPropertiesView(schemaObj, getInitData);
|
|
});
|
|
|
|
it('create collection', async ()=>{
|
|
let schemaCollObj = new ColumnInColl();
|
|
const {ctrl, user} = await getCreateView(schemaCollObj);
|
|
/* Make sure you hit every corner */
|
|
|
|
await addNewDatagridRow(user, ctrl);
|
|
});
|
|
|
|
it('isTypeIdentity', ()=>{
|
|
let state = {colconstype: 'i'};
|
|
expect(schemaObj.isTypeIdentity(state)).toBe(true);
|
|
});
|
|
|
|
it('isTypeGenerated', ()=>{
|
|
let state = {colconstype: 'g'};
|
|
expect(schemaObj.isTypeGenerated(state)).toBe(true);
|
|
});
|
|
|
|
it('inSchemaWithModelCheck', ()=>{
|
|
let state = {attnum: 1};
|
|
schemaObj.nodeInfo.schema = {};
|
|
expect(schemaObj.inSchemaWithModelCheck(state)).toBe(true);
|
|
state.attnum = null;
|
|
expect(schemaObj.inSchemaWithModelCheck(state)).toBe(false);
|
|
schemaObj.nodeInfo = {};
|
|
expect(schemaObj.inSchemaWithModelCheck(state)).toBe(true);
|
|
});
|
|
|
|
it('attlenRange', ()=>{
|
|
schemaObj.datatypes = datatypes;
|
|
let state = {cltype: 'character varying'};
|
|
expect(schemaObj.attlenRange(state)).toEqual({min: 1, max: 140391});
|
|
});
|
|
|
|
it('attprecisionRange', ()=>{
|
|
schemaObj.datatypes = datatypes;
|
|
let state = {cltype: 'numeric'};
|
|
expect(schemaObj.attprecisionRange(state)).toEqual({min: -140391, max: 140391});
|
|
});
|
|
|
|
it('inSchemaWithColumnCheck', ()=>{
|
|
let state = {};
|
|
schemaObj.nodeInfo = {schema: {}};
|
|
expect(schemaObj.inSchemaWithColumnCheck(state)).toBe(false);
|
|
|
|
state.attnum = -1;
|
|
expect(schemaObj.inSchemaWithColumnCheck(state)).toBe(true);
|
|
|
|
state.inheritedfrom = 140391;
|
|
expect(schemaObj.inSchemaWithColumnCheck(state)).toBe(true);
|
|
|
|
schemaObj.nodeInfo.view = {};
|
|
expect(schemaObj.inSchemaWithColumnCheck(state)).toBe(true);
|
|
|
|
schemaObj.nodeInfo = {};
|
|
expect(schemaObj.inSchemaWithColumnCheck(state)).toBe(false);
|
|
});
|
|
|
|
it('editableCheckForTable', ()=>{
|
|
let state = {};
|
|
schemaObj.nodeInfo = {};
|
|
expect(schemaObj.editableCheckForTable(state)).toBe(true);
|
|
});
|
|
|
|
it('depChange', ()=>{
|
|
schemaObj.datatypes = datatypes;
|
|
let state = {cltype: 'numeric'};
|
|
getFieldDepChange(schemaObj, 'collspcname')(state);
|
|
|
|
expect(getFieldDepChange(schemaObj, 'attlen')(state)).toEqual({
|
|
cltype: 'numeric',
|
|
min_val_attlen: 1,
|
|
max_val_attlen: 140391,
|
|
});
|
|
|
|
expect(getFieldDepChange(schemaObj, 'attprecision')(state)).toEqual({
|
|
cltype: 'numeric',
|
|
min_val_attprecision: -140391,
|
|
max_val_attprecision: 140391,
|
|
});
|
|
});
|
|
|
|
it('validate', ()=>{
|
|
let state = {};
|
|
let setError = jest.fn();
|
|
|
|
state.cltype = 'bigint';
|
|
state.min_val_attlen = 5;
|
|
state.max_val_attlen = 10;
|
|
state.attlen = 3;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('attlen', 'Length/Precision should not be less than: 5');
|
|
state.attlen = 11;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('attlen', 'Length/Precision should not be greater than: 10');
|
|
|
|
state.attlen = 6;
|
|
state.min_val_attprecision = 5;
|
|
state.max_val_attprecision = 10;
|
|
state.attprecision = 3;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('attprecision', 'Scale should not be less than: 5');
|
|
state.attprecision = 11;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('attprecision', 'Scale should not be greater than: 10');
|
|
|
|
state.attprecision = 6;
|
|
state.colconstype = 'g';
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('genexpr', 'Expression value cannot be empty.');
|
|
|
|
state.attnum = 1;
|
|
state.attidentity = 'a';
|
|
state.colconstype = 'i';
|
|
schemaObj.origData = {attidentity:'a'};
|
|
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqincrement', 'Increment value cannot be empty.');
|
|
|
|
state.seqincrement = 1;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqmin', 'Minimum value cannot be empty.');
|
|
|
|
state.seqmin = 1;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqmax', 'Maximum value cannot be empty.');
|
|
|
|
state.seqmax = 1;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqcache', 'Cache value cannot be empty.');
|
|
|
|
state.attnum = null;
|
|
state.seqmin = null;
|
|
state.seqmax = null;
|
|
schemaObj.origData.attidentity = undefined;
|
|
expect(schemaObj.validate(state, setError)).toBe(false);
|
|
|
|
state.seqmin = 3;
|
|
state.seqmax = 2;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqmin', 'Minimum value must be less than maximum value.');
|
|
|
|
state.seqmin = 3;
|
|
state.seqmax = 5;
|
|
state.seqstart = 2;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqstart', 'Start value cannot be less than minimum value.');
|
|
|
|
state.seqstart = 6;
|
|
schemaObj.validate(state, setError);
|
|
expect(setError).toHaveBeenCalledWith('seqstart', 'Start value cannot be greater than maximum value.');
|
|
|
|
|
|
state.seqstart = 4;
|
|
expect(schemaObj.validate(state, setError)).toBe(false);
|
|
});
|
|
});
|
|
|