From 1971c437ba4563fd11efcbf08fe9d6bf785f3d55 Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Tue, 3 May 2022 00:47:55 +0900 Subject: [PATCH] Fix #10384: test: Skip tests for imgconvert if imagemagick not found --- tests/test_ext_imgconverter.py | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tests/test_ext_imgconverter.py b/tests/test_ext_imgconverter.py index 134947c87..77fa26c7a 100644 --- a/tests/test_ext_imgconverter.py +++ b/tests/test_ext_imgconverter.py @@ -1,12 +1,26 @@ """Test sphinx.ext.imgconverter extension.""" -import os +import subprocess +from subprocess import PIPE import pytest +@pytest.fixture +def if_converter_found(app): + image_converter = getattr(app.config, 'image_converter', '') + try: + if image_converter: + subprocess.run([image_converter, '-version'], stdout=PIPE, stderr=PIPE) # show version + return + except OSError: # No such file or directory + pass + + pytest.skip('image_converter "%s" is not available' % image_converter) + + +@pytest.mark.usefixtures('if_converter_found') @pytest.mark.sphinx('latex', testroot='ext-imgconverter') -@pytest.mark.xfail(os.name != 'posix', reason="Not working on windows") def test_ext_imgconverter(app, status, warning): app.builder.build_all()