IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9943 from jdknight/drop-translator-specific-unknown_visit-calls

Browse Source 
drop translator-specific unknown_visit calls
This commit is contained in:
Takeshi KOMIYA 2021-12-24 02:09:16 +09:00 committed by GitHub
commit 048fd80cb4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sphinx/util/docutils.py
View File

@ -28,7 +28,7 @@ from docutils.utils import Reporter, unescape
from packaging import version from packaging import version
from sphinx.errors import SphinxError from sphinx.errors import SphinxError
from sphinx.locale import _ from sphinx.locale import _, __
from sphinx.util import logging from sphinx.util import logging
from sphinx.util.typing import RoleFunction from sphinx.util.typing import RoleFunction
@ -496,6 +496,9 @@ class SphinxTranslator(nodes.NodeVisitor):
else: else:
super().dispatch_departure(node) super().dispatch_departure(node)
def unknown_visit(self, node: Node) -> None:
logger.warning(__('unknown node type: %r'), node, location=node)
# cache a vanilla instance of nodes.document # cache a vanilla instance of nodes.document
# Used in new_document() function # Used in new_document() function

3
sphinx/writers/html.py
View File

@ -876,9 +876,6 @@ class HTMLTranslator(SphinxTranslator, BaseTranslator):
if depart: if depart:
depart(self, node) depart(self, node)
def unknown_visit(self, node: Node) -> None:
raise NotImplementedError('Unknown node: ' + node.__class__.__name__)
@property @property
def permalink_text(self) -> str: def permalink_text(self) -> str:
warnings.warn('HTMLTranslator.permalink_text is deprecated.', warnings.warn('HTMLTranslator.permalink_text is deprecated.',

3
sphinx/writers/html5.py
View File

@ -811,9 +811,6 @@ class HTML5Translator(SphinxTranslator, BaseTranslator):
if depart: if depart:
depart(self, node) depart(self, node)
def unknown_visit(self, node: Node) -> None:
raise NotImplementedError('Unknown node: ' + node.__class__.__name__)
@property @property
def permalink_text(self) -> str: def permalink_text(self) -> str:
warnings.warn('HTMLTranslator.permalink_text is deprecated.', warnings.warn('HTMLTranslator.permalink_text is deprecated.',

3
sphinx/writers/latex.py
View File

@ -2077,9 +2077,6 @@ class LaTeXTranslator(SphinxTranslator):
def depart_math_reference(self, node: Element) -> None: def depart_math_reference(self, node: Element) -> None:
pass pass
def unknown_visit(self, node: Node) -> None:
raise NotImplementedError('Unknown node: ' + node.__class__.__name__)
# FIXME: Workaround to avoid circular import # FIXME: Workaround to avoid circular import
# refs: https://github.com/sphinx-doc/sphinx/issues/5433 # refs: https://github.com/sphinx-doc/sphinx/issues/5433

5
sphinx/writers/manpage.py
View File

@ -11,7 +11,7 @@
from typing import Any, Dict, Iterable, cast from typing import Any, Dict, Iterable, cast
from docutils import nodes from docutils import nodes
from docutils.nodes import Element, Node, TextElement from docutils.nodes import Element, TextElement
from docutils.writers.manpage import Translator as BaseTranslator from docutils.writers.manpage import Translator as BaseTranslator
from docutils.writers.manpage import Writer from docutils.writers.manpage import Writer
@ -462,6 +462,3 @@ class ManualPageTranslator(SphinxTranslator, BaseTranslator):
def depart_math_block(self, node: Element) -> None: def depart_math_block(self, node: Element) -> None:
self.depart_centered(node) self.depart_centered(node)
def unknown_visit(self, node: Node) -> None:
raise NotImplementedError('Unknown node: ' + node.__class__.__name__)

4
sphinx/writers/texinfo.py
View File

@ -1281,10 +1281,6 @@ class TexinfoTranslator(SphinxTranslator):
logger.warning(__("unimplemented node type: %r"), node, logger.warning(__("unimplemented node type: %r"), node,
location=node) location=node)
def unknown_visit(self, node: Node) -> None:
logger.warning(__("unknown node type: %r"), node,
location=node)
def unknown_departure(self, node: Node) -> None: def unknown_departure(self, node: Node) -> None:
pass pass

5
sphinx/writers/text.py
View File

@ -16,7 +16,7 @@ from typing import (TYPE_CHECKING, Any, Dict, Generator, Iterable, List, Optiona
Union, cast) Union, cast)
from docutils import nodes, writers from docutils import nodes, writers
from docutils.nodes import Element, Node, Text from docutils.nodes import Element, Text
from docutils.utils import column_width from docutils.utils import column_width
from sphinx import addnodes from sphinx import addnodes
@ -1189,6 +1189,3 @@ class TextTranslator(SphinxTranslator):
def depart_math_block(self, node: Element) -> None: def depart_math_block(self, node: Element) -> None:
self.end_state() self.end_state()
def unknown_visit(self, node: Node) -> None:
raise NotImplementedError('Unknown node: ' + node.__class__.__name__)