From 227955cbe8ff70b61ae2e8d04f64a77255513de6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Freitag?= Date: Wed, 27 Jan 2021 17:11:41 +0100 Subject: [PATCH] linkcheck: Raise on unknown status in process_result() Helps catching programming errors. The else clause should never be reached. --- sphinx/builders/linkcheck.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sphinx/builders/linkcheck.py b/sphinx/builders/linkcheck.py index 106303bd6..9a5ca6041 100644 --- a/sphinx/builders/linkcheck.py +++ b/sphinx/builders/linkcheck.py @@ -428,6 +428,8 @@ class CheckExternalLinksBuilder(DummyBuilder): self.write_entry('redirected ' + text, docname, filename, lineno, uri + ' to ' + info) self.write_linkstat(linkstat) + else: + raise ValueError("Unknown status %s." % status) def write_entry(self, what: str, docname: str, filename: str, line: int, uri: str) -> None: