From c26d5d7ecd61a83f4e75035d205519a0bd5502f3 Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Sun, 14 Apr 2019 19:19:02 +0900 Subject: [PATCH] refactor: separate ReSTMarkup.get_index_text() to subclasses According to the principle, the parent class; ReSTMarkup should not know about children. --- sphinx/domains/rst.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sphinx/domains/rst.py b/sphinx/domains/rst.py index 716b50105..a7a863373 100644 --- a/sphinx/domains/rst.py +++ b/sphinx/domains/rst.py @@ -58,10 +58,6 @@ class ReSTMarkup(ObjectDescription): def get_index_text(self, objectname, name): # type: (str, str) -> str - if self.objtype == 'directive': - return _('%s (directive)') % name - elif self.objtype == 'role': - return _('%s (role)') % name return '' @@ -96,6 +92,10 @@ class ReSTDirective(ReSTMarkup): signode += addnodes.desc_addname(args, args) return name + def get_index_text(self, objectname, name): + # type: (str, str) -> str + return _('%s (directive)') % name + class ReSTRole(ReSTMarkup): """ @@ -106,6 +106,10 @@ class ReSTRole(ReSTMarkup): signode += addnodes.desc_name(':%s:' % sig, ':%s:' % sig) return sig + def get_index_text(self, objectname, name): + # type: (str, str) -> str + return _('%s (role)') % name + class ReSTDomain(Domain): """ReStructuredText domain."""