From 488d3263f3cf77fc351e92ff1170063f6459c35b Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Fri, 30 Nov 2018 00:18:47 +0900 Subject: [PATCH] Fix annotations for writers --- sphinx/writers/html.py | 4 ++-- sphinx/writers/html5.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sphinx/writers/html.py b/sphinx/writers/html.py index c95c7c2f4..4cfd9ad79 100644 --- a/sphinx/writers/html.py +++ b/sphinx/writers/html.py @@ -285,7 +285,7 @@ class HTMLTranslator(BaseTranslator): # overwritten def visit_admonition(self, node, name=''): - # type: (nodes.admonition, unicode) -> None + # type: (nodes.Element, unicode) -> None self.body.append(self.starttag( node, 'div', CLASS=('admonition ' + name))) if name: @@ -372,7 +372,7 @@ class HTMLTranslator(BaseTranslator): # overwritten def visit_bullet_list(self, node): # type: (nodes.bullet_list) -> None - if len(node) == 1 and node[0].tagname == 'toctree': + if len(node) == 1 and isinstance(node[0], addnodes.toctree): # avoid emitting empty raise nodes.SkipNode self.generate_targets_for_listing(node) diff --git a/sphinx/writers/html5.py b/sphinx/writers/html5.py index 1b499823b..fcf00c7a5 100644 --- a/sphinx/writers/html5.py +++ b/sphinx/writers/html5.py @@ -221,7 +221,7 @@ class HTML5Translator(BaseTranslator): if self.settings.cloak_email_addresses and \ atts['href'].startswith('mailto:'): atts['href'] = self.cloak_mailto(atts['href']) - self.in_mailto = 1 + self.in_mailto = True else: assert 'refid' in node, \ 'References must have "refuri" or "refid" attribute.' @@ -254,7 +254,7 @@ class HTML5Translator(BaseTranslator): # overwritten def visit_admonition(self, node, name=''): - # type: (nodes.admonition, unicode) -> None + # type: (nodes.Element, unicode) -> None self.body.append(self.starttag( node, 'div', CLASS=('admonition ' + name))) if name: @@ -325,7 +325,7 @@ class HTML5Translator(BaseTranslator): # overwritten def visit_bullet_list(self, node): # type: (nodes.bullet_list) -> None - if len(node) == 1 and node[0].tagname == 'toctree': + if len(node) == 1 and isinstance(node[0], addnodes.toctree): # avoid emitting empty raise nodes.SkipNode super(HTML5Translator, self).visit_bullet_list(node)