From 615c0f80919b0cf6027a77b2608f870c3848bba2 Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Sat, 2 Mar 2019 21:07:54 +0900 Subject: [PATCH] Fix #5391: A cross reference in heading is rendered as literal --- CHANGES | 1 + sphinx/transforms/__init__.py | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/CHANGES b/CHANGES index 0e0998c32..32a3e9d9e 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,7 @@ Bugs fixed * #5508: ``linenothreshold`` option for ``highlight`` directive was ignored * texinfo: ``make install-info`` causes syntax error * texinfo: ``make install-info`` fails on macOS +* #5391: A cross reference in heading is rendered as literal Testing -------- diff --git a/sphinx/transforms/__init__.py b/sphinx/transforms/__init__.py index 890cfcb84..636abfee2 100644 --- a/sphinx/transforms/__init__.py +++ b/sphinx/transforms/__init__.py @@ -340,11 +340,7 @@ class SphinxContentsFilter(ContentsFilter): Used with BuildEnvironment.add_toc_from() to discard cross-file links within table-of-contents link nodes. """ - def visit_pending_xref(self, node): - # type: (addnodes.pending_xref) -> None - text = node.astext() - self.parent.append(nodes.literal(text, text)) - raise nodes.SkipNode + visit_pending_xref = ContentsFilter.ignore_node_but_process_children def visit_image(self, node): # type: (nodes.image) -> None