From 72985c250b55a9dc07141e9a110937df24b16373 Mon Sep 17 00:00:00 2001 From: Vasista Vovveti Date: Tue, 20 Oct 2020 12:43:10 -0500 Subject: [PATCH] Fix broken url not reporting error Some links are printed as broken but do not error out the build. This issue appeared when include `tel:` links in our build. --- sphinx/builders/linkcheck.py | 1 + 1 file changed, 1 insertion(+) diff --git a/sphinx/builders/linkcheck.py b/sphinx/builders/linkcheck.py index 9b54afc7c..7ea1259b7 100644 --- a/sphinx/builders/linkcheck.py +++ b/sphinx/builders/linkcheck.py @@ -226,6 +226,7 @@ class CheckExternalLinksBuilder(Builder): if rex.match(uri): return 'ignored', '', 0 else: + self.broken[uri] = '' return 'broken', '', 0 elif uri in self.good: return 'working', 'old', 0