From 7586297d6df6fbae4b860a604422d4eddc40b32e Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Sat, 18 Jun 2016 10:25:43 +0900 Subject: [PATCH] Fix #2684: `sphinx.ext.intersphinx` crashes with six-1.4.1 --- CHANGES | 1 + sphinx/ext/intersphinx.py | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGES b/CHANGES index 5a091f3e3..3d36e00c5 100644 --- a/CHANGES +++ b/CHANGES @@ -12,6 +12,7 @@ Bugs fixed * #2676: (latex) Error with verbatim text in captions since Sphinx 1.4.4 * #2629: memoir class crashes LaTeX. Fixed ``by latex_keep_old_macro_names=False`` (ref 2675) +* #2684: `sphinx.ext.intersphinx` crashes with six-1.4.1 Release 1.4.4 (released Jun 12, 2016) diff --git a/sphinx/ext/intersphinx.py b/sphinx/ext/intersphinx.py index 350121190..617220c5f 100644 --- a/sphinx/ext/intersphinx.py +++ b/sphinx/ext/intersphinx.py @@ -34,7 +34,8 @@ from os import path import re from six import iteritems, string_types -from six.moves.urllib import parse, request +from six.moves.urllib import request +from six.moves.urllib.parse import urlsplit, urlunsplit from docutils import nodes from docutils.utils import relative_path @@ -145,7 +146,7 @@ def _strip_basic_auth(url): :rtype: ``tuple`` """ - url_parts = parse.urlsplit(url) + url_parts = urlsplit(url) username = url_parts.username password = url_parts.password frags = list(url_parts) @@ -154,7 +155,7 @@ def _strip_basic_auth(url): frags[1] = "%s:%s" % (url_parts.hostname, url_parts.port) else: frags[1] = url_parts.hostname - url = parse.urlunsplit(frags) + url = urlunsplit(frags) return (url, username, password) @@ -208,12 +209,12 @@ def _get_safe_url(url): url, username, _ = _strip_basic_auth(url) if username is not None: # case: url contained basic auth creds; obscure password - url_parts = parse.urlsplit(url) + url_parts = urlsplit(url) safe_netloc = '{0}@{1}'.format(username, url_parts.hostname) # replace original netloc w/ obscured version frags = list(url_parts) frags[1] = safe_netloc - safe_url = parse.urlunsplit(frags) + safe_url = urlunsplit(frags) return safe_url