From 7f229582e7013e79518bf4561a36479416d64068 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Sat, 15 Dec 2018 18:18:27 -0800 Subject: [PATCH] Remove unnecessary bytes/str type check from doctree_read() ModuleAnalyzer.code is always type str. Decoding is unnecessary. --- sphinx/ext/viewcode.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sphinx/ext/viewcode.py b/sphinx/ext/viewcode.py index 409ff4a86..3fdafce3e 100644 --- a/sphinx/ext/viewcode.py +++ b/sphinx/ext/viewcode.py @@ -13,7 +13,6 @@ import traceback import warnings from docutils import nodes -from six import text_type import sphinx from sphinx import addnodes @@ -75,12 +74,8 @@ def doctree_read(app, doctree): env._viewcode_modules[modname] = False # type: ignore return - if not isinstance(analyzer.code, text_type): - code = analyzer.code.decode(analyzer.encoding) - else: - code = analyzer.code - analyzer.find_tags() + code = analyzer.code tags = analyzer.tags else: code, tags = code_tags