IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3671 from tk0miya/3669_gettext_raises_ValueError

Browse Source 
3669 gettext raises value error
This commit is contained in:
Takeshi KOMIYA 2017-04-27 01:10:11 +09:00 committed by GitHub
commit 84213da197
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -16,6 +16,7 @@ Bugs fixed
---------- ----------
* #3661: sphinx-build crashes on parallel build * #3661: sphinx-build crashes on parallel build
* #3669: gettext builder fails with "ValueError: substring not found"
Testing Testing
-------- --------

4
sphinx/builders/gettext.py
View File

@ -194,6 +194,7 @@ ltz = LocalTimeZone()
def should_write(filepath, new_content): def should_write(filepath, new_content):
if not path.exists(filepath): if not path.exists(filepath):
return True return True
try:
with open(filepath, 'r', encoding='utf-8') as oldpot: # type: ignore with open(filepath, 'r', encoding='utf-8') as oldpot: # type: ignore
old_content = oldpot.read() old_content = oldpot.read()
old_header_index = old_content.index('"POT-Creation-Date:') old_header_index = old_content.index('"POT-Creation-Date:')
@ -202,6 +203,9 @@ def should_write(filepath, new_content):
new_body_index = new_content.index('"PO-Revision-Date:') new_body_index = new_content.index('"PO-Revision-Date:')
return ((old_content[:old_header_index] != new_content[:new_header_index]) or return ((old_content[:old_header_index] != new_content[:new_header_index]) or
(new_content[new_body_index:] != old_content[old_body_index:])) (new_content[new_body_index:] != old_content[old_body_index:]))
except ValueError:
pass
return True return True