From 85138ff449916add6a5ccb5f0299163069ac1fcd Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Tue, 18 Feb 2020 00:23:23 +0900 Subject: [PATCH] Fix #7137: viewcode: Avoid to crash when non-python code given --- CHANGES | 1 + sphinx/ext/viewcode.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 1429e39d5..2dd62f02b 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,7 @@ Bugs fixed * #7146: autodoc: IndexError is raised on suppressed type_comment found * #7161: autodoc: typehints extension does not support parallel build * #7151: crashed when extension assigns a value to ``env.indexentries`` +* #7137: viewcode: Avoid to crash when non-python code given Testing -------- diff --git a/sphinx/ext/viewcode.py b/sphinx/ext/viewcode.py index e9081c891..82c2111ef 100644 --- a/sphinx/ext/viewcode.py +++ b/sphinx/ext/viewcode.py @@ -66,11 +66,11 @@ def doctree_read(app: Sphinx, doctree: Node) -> None: if code_tags is None: try: analyzer = ModuleAnalyzer.for_module(modname) + analyzer.find_tags() except Exception: env._viewcode_modules[modname] = False # type: ignore return - analyzer.find_tags() code = analyzer.code tags = analyzer.tags else: