IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix #5070: epub: Wrong internal href fragment links

Browse Source
This commit is contained in:
Takeshi KOMIYA 2019-10-14 01:03:50 +09:00
parent f59ebed3bd
commit 93d659568d
4 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -33,6 +33,7 @@ Bugs fixed
* #6584: i18n: Error when compiling message catalogs on Hindi * #6584: i18n: Error when compiling message catalogs on Hindi
* #6708: mathbase: Some deprecated functions have removed * #6708: mathbase: Some deprecated functions have removed
* #6709: autodoc: mock object does not work as a class decorator * #6709: autodoc: mock object does not work as a class decorator
* #5070: epub: Wrong internal href fragment links
* #6712: Allow not to install sphinx.testing as runtime (mainly for ALT Linux) * #6712: Allow not to install sphinx.testing as runtime (mainly for ALT Linux)
Testing Testing

2
sphinx/builders/_epub_base.py
View File

@ -272,7 +272,7 @@ class EpubBuilder(StandaloneHTMLBuilder):
if ':' in node_id: if ':' in node_id:
target['ids'][i] = self.fix_fragment('', node_id) target['ids'][i] = self.fix_fragment('', node_id)
next_node = target.next_node(siblings=True) # type: Node next_node = target.next_node(ascend=True) # type: Node
if isinstance(next_node, nodes.Element): if isinstance(next_node, nodes.Element):
for i, node_id in enumerate(next_node['ids']): for i, node_id in enumerate(next_node['ids']):
if ':' in node_id: if ':' in node_id:

5
tests/roots/test-epub-anchor-id/index.rst
View File

@ -5,4 +5,9 @@ test-epub-anchor-id
blah blah blah blah blah blah
.. setting:: STATICFILES_SECTION
blah blah blah
==============
see :setting:`STATICFILES_FINDERS` see :setting:`STATICFILES_FINDERS`

1
tests/test_build_epub.py
View File

@ -321,6 +321,7 @@ def test_epub_anchor_id(app):
html = (app.outdir / 'index.xhtml').text() html = (app.outdir / 'index.xhtml').text()
assert '<p id="std-setting-STATICFILES_FINDERS">blah blah blah</p>' in html assert '<p id="std-setting-STATICFILES_FINDERS">blah blah blah</p>' in html
assert '<span id="std-setting-STATICFILES_SECTION"></span><h1>blah blah blah</h1>' in html
assert 'see <a class="reference internal" href="#std-setting-STATICFILES_FINDERS">' in html assert 'see <a class="reference internal" href="#std-setting-STATICFILES_FINDERS">' in html