From 9f889932815dea46f8e97c732aaa8216e4b37c08 Mon Sep 17 00:00:00 2001 From: Craig Rodrigues Date: Fri, 15 Sep 2017 14:45:56 -0700 Subject: [PATCH] hashlib.sha1() must take bytes, not unicode --- sphinx/transforms/post_transforms/images.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sphinx/transforms/post_transforms/images.py b/sphinx/transforms/post_transforms/images.py index c57355774..df207f8ad 100644 --- a/sphinx/transforms/post_transforms/images.py +++ b/sphinx/transforms/post_transforms/images.py @@ -70,7 +70,7 @@ class ImageDownloader(BaseImageConverter): if '?' in basename: basename = basename.split('?')[0] if basename == '': - basename = sha1(node['uri']).hexdigest() + basename = sha1(node['uri'].encode("utf-8")).hexdigest() dirname = node['uri'].replace('://', '/').translate({ord("?"): u"/", ord("&"): u"/"}) ensuredir(os.path.join(self.imagedir, dirname))