Merge branch '1.8'

CHANGES

@@ -196,7 +196,7 @@ Testing
 
 * Stop to use ``SPHINX_TEST_TEMPDIR`` envvar
 
-Release 1.8.4 (in development)
+Release 1.8.5 (in development)
 ==============================
 
 Dependencies
@@ -213,6 +213,16 @@ Features added
 
 Bugs fixed
 ----------
+
+Testing
+--------
+
+Release 1.8.4 (released Feb 03, 2019)
+=====================================
+
+Bugs fixed
+----------
+
 * #3707: latex: no bold checkmark (✔) available.
 * #5605: with the documentation language set to Chinese, English words could not
   be searched.
@@ -231,13 +241,11 @@ Bugs fixed
 * #5966: mathjax has not been loaded on incremental build
 * #5960: LaTeX: modified PDF layout since September 2018 TeXLive update of
   :file:`parskip.sty`
+* #5948: LaTeX: duplicated labels are generated for sections
 * #5958: versionadded directive causes crash with Python 3.5.0
 * #5995: autodoc: autodoc_mock_imports conflict with metaclass on Python 3.7
 * #5871: texinfo: a section title ``.`` is not allowed
 
-Testing
---------
-
 Release 1.8.3 (released Dec 26, 2018)
 =====================================
 

sphinx/writers/latex.py

@@ -1752,10 +1752,9 @@ class LaTeXTranslator(SphinxTranslator):
         elif domain.get_enumerable_node_type(next_node) and domain.get_numfig_title(next_node):
             return
 
-        if 'refuri' in node:
+        if 'refuri' in node or 'refid' in node or 'refname' in node:
+            # skip indirect targets (external hyperlink and internal links)
             return
-        if node.get('refid'):
-            add_target(node['refid'])
         for id in node['ids']:
             add_target(id)
 

tests/roots/test-latex-labels/index.rst

@@ -68,3 +68,5 @@ subsubsection
 .. toctree::
 
    otherdoc
+
+* Embeded standalone hyperlink reference(refs: #5948): `subsection <section1_>`_.

tests/test_build_latex.py

@@ -1372,6 +1372,9 @@ def test_latex_labels(app, status, warning):
             r'\label{\detokenize{otherdoc:otherdoc}}'
             r'\label{\detokenize{otherdoc::doc}}' in result)
 
+    # Embeded standalone hyperlink reference (refs: #5948)
+    assert result.count(r'\label{\detokenize{index:section1}}') == 1
+
 
 def test_default_latex_documents():
     from sphinx.util import texescape