Apply refurb/ruff rule FURB145 (#11848)

sphinx/domains/changeset.py

@@ -126,7 +126,7 @@ class ChangeSetDomain(Domain):
 
     def clear_doc(self, docname: str) -> None:
         for changes in self.changesets.values():
-            for changeset in changes[:]:
+            for changeset in changes.copy():
                 if changeset.docname == docname:
                     changes.remove(changeset)
 

sphinx/events.py

@@ -77,7 +77,7 @@ class EventManager:
     def disconnect(self, listener_id: int) -> None:
         """Disconnect a handler."""
         for listeners in self.listeners.values():
-            for listener in listeners[:]:
+            for listener in listeners.copy():
                 if listener.id == listener_id:
                     listeners.remove(listener)
 

sphinx/ext/apidoc.py

@@ -168,7 +168,7 @@ def create_modules_toc_file(modules: list[str], opts: Any, name: str = 'modules'
     """Create the module's index."""
     modules.sort()
     prev_module = ''
-    for module in modules[:]:
+    for module in modules.copy():
         # look if the module is a subpackage and, if yes, ignore it
         if module.startswith(prev_module + '.'):
             modules.remove(module)
@@ -268,7 +268,7 @@ def recurse_tree(rootpath: str, excludes: Sequence[re.Pattern[str]], opts: Any,
         is_pkg = is_packagedir(None, files)
         is_namespace = not is_pkg and implicit_namespaces
         if is_pkg:
-            for f in files[:]:
+            for f in files.copy():
                 if is_initpy(f):
                     files.remove(f)
                     files.insert(0, f)

sphinx/ext/autodoc/__init__.py

@@ -221,7 +221,7 @@ def between(
             return
         deleted = 0
         delete = not exclude
-        orig_lines = lines[:]
+        orig_lines = lines.copy()
         for i, line in enumerate(orig_lines):
             if delete:
                 lines.pop(i - deleted)

sphinx/ext/napoleon/__init__.py

@@ -389,7 +389,7 @@ def _process_docstring(app: Sphinx, what: str, name: str, obj: Any,
         docstring = GoogleDocstring(result_lines, app.config, app, what, name,
                                     obj, options)
         result_lines = docstring.lines()
-    lines[:] = result_lines[:]
+    lines[:] = result_lines.copy()
 
 
 def _skip_member(app: Sphinx, what: str, name: str, obj: Any,

sphinx/testing/fixtures.py

@@ -174,7 +174,7 @@ def make_app(test_params: dict, monkeypatch: Any) -> Generator[Callable, None, N
     instead of using SphinxTestApp class directory.
     """
     apps = []
-    syspath = sys.path[:]
+    syspath = sys.path.copy()
 
     def make(*args, **kwargs):
         status, warning = StringIO(), StringIO()

sphinx/testing/util.py

@@ -109,7 +109,7 @@ class SphinxTestApp(application.Sphinx):
             confoverrides = {}
         warningiserror = False
 
-        self._saved_path = sys.path[:]
+        self._saved_path = sys.path.copy()
         self._saved_directives = directives._directives.copy()  # type: ignore[attr-defined]
         self._saved_roles = roles._roles.copy()  # type: ignore[attr-defined]
 

sphinx/util/fileutil.py

@@ -81,7 +81,7 @@ def copy_asset(source: str | os.PathLike[str], destination: str | os.PathLike[st
 
     for root, dirs, files in os.walk(source, followlinks=True):
         reldir = relative_path(source, root)  # type: ignore[arg-type]
-        for dir in dirs[:]:
+        for dir in dirs.copy():
             if excluded(posixpath.join(reldir, dir)):
                 dirs.remove(dir)
             else:

sphinx/writers/latex.py

@@ -321,7 +321,7 @@ class LaTeXTranslator(SphinxTranslator):
         self.elements = self.builder.context.copy()
 
         # initial section names
-        self.sectionnames = LATEXSECTIONNAMES[:]
+        self.sectionnames = LATEXSECTIONNAMES.copy()
         if self.theme.toplevel_sectioning == 'section':
             self.sectionnames.remove('chapter')