IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

[search] filter script and style elements from search result summary text. (#12057)

Browse Source 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This commit is contained in:
James Addison 2024-03-17 14:14:03 +00:00 committed by GitHub
parent b2069fb64f
commit bf0bec3b4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 33 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES.rst
View File

@ -109,6 +109,9 @@ Bugs fixed
Patch by Bénédikt Tran. Patch by Bénédikt Tran.
* #11894: Do not add checksums to css files if building using the htmlhelp builder. * #11894: Do not add checksums to css files if building using the htmlhelp builder.
Patch by mkay. Patch by mkay.
* #12052: Remove ``<script>`` and ``<style>`` tags from the content of search result
summary snippets.
Patch by James Addison.
Testing Testing
------- -------

4
sphinx/themes/basic/static/searchtools.js
View File

@ -162,7 +162,9 @@ const Search = {
htmlToText: (htmlString, anchor) => { htmlToText: (htmlString, anchor) => {
const htmlElement = new DOMParser().parseFromString(htmlString, 'text/html'); const htmlElement = new DOMParser().parseFromString(htmlString, 'text/html');
htmlElement.querySelectorAll(".headerlink").forEach((el) => { el.remove() }); for (const removalQuery of [".headerlinks", "script", "style"]) {
htmlElement.querySelectorAll(removalQuery).forEach((el) => { el.remove() });
}
if (anchor) { if (anchor) {
const anchorContent = htmlElement.querySelector(`[role="main"] ${anchor}`); const anchorContent = htmlElement.querySelector(`[role="main"] ${anchor}`);
if (anchorContent) return anchorContent.textContent; if (anchorContent) return anchorContent.textContent;

41
tests/js/searchtools.js
View File

@ -61,20 +61,33 @@ describe('Basic html theme search', function() {
describe("htmlToText", function() { describe("htmlToText", function() {
const testHTML = `<html> const testHTML = `<html>
<div class="body" role="main"> <body>
<section id="getting-started"> <script src="directory/filename.js"></script>
<h1>Getting Started</h1> <div class="body" role="main">
<p>Some text</p> <script>
</section> console.log('dynamic');
<section id="other-section"> </script>
<h1>Other Section</h1> <style>
<p>Other text</p> div.body p.centered {
</section> text-align: center;
<section id="yet-another-section"> margin-top: 25px;
<h1>Yet Another Section</h1> }
<p>More text</p> </style>
</section> <!-- main content -->
</div> <section id="getting-started">
<h1>Getting Started</h1>
<p>Some text</p>
</section>
<section id="other-section">
<h1>Other Section</h1>
<p>Other text</p>
</section>
<section id="yet-another-section">
<h1>Yet Another Section</h1>
<p>More text</p>
</section>
</div>
</body>
</html>`; </html>`;
it("basic case", () => { it("basic case", () => {