From bf62a968319be9bdc735b3e855f505b4b1bdbedc Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Fri, 11 Jan 2019 01:22:02 +0900 Subject: [PATCH] refactor applehelp: Use shlex.quote() instead of pipes.quote() --- sphinx/builders/applehelp.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sphinx/builders/applehelp.py b/sphinx/builders/applehelp.py index 31ff240e2..f1db441b9 100644 --- a/sphinx/builders/applehelp.py +++ b/sphinx/builders/applehelp.py @@ -8,7 +8,6 @@ :license: BSD, see LICENSE for details. """ -import pipes import plistlib import shlex import subprocess @@ -205,7 +204,7 @@ class AppleHelpBuilder(StandaloneHTMLBuilder): if self.config.applehelp_disable_external_tools: logger.info(__('skipping')) logger.warning(__('you will need to index this help book with:\n %s'), - ' '.join([pipes.quote(arg) for arg in args])) + ' '.join([shlex.quote(arg) for arg in args])) else: try: p = subprocess.Popen(args, @@ -240,7 +239,7 @@ class AppleHelpBuilder(StandaloneHTMLBuilder): if self.config.applehelp_disable_external_tools: logger.info(__('skipping')) logger.warning(__('you will need to sign this help book with:\n %s'), - ' '.join([pipes.quote(arg) for arg in args])) + ' '.join([shlex.quote(arg) for arg in args])) else: try: p = subprocess.Popen(args,