From c35886f6d05ef29f4aae15a8395f1c280bd99342 Mon Sep 17 00:00:00 2001 From: tk0miya Date: Sat, 27 Sep 2014 16:17:25 +0900 Subject: [PATCH] Refactor has_child() function (by review) --- sphinx/environment.py | 6 +----- sphinx/transforms.py | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/sphinx/environment.py b/sphinx/environment.py index fad5f2b36..d9be0be5f 100644 --- a/sphinx/environment.py +++ b/sphinx/environment.py @@ -1706,11 +1706,7 @@ class BuildEnvironment: fignum_counter = {} def has_child(node, cls): - for child in node: - if isinstance(child, cls): - return True - - return False + return any(isinstance(child, cls) for child in node) def get_section_number(docname, section): anchorname = '#' + section['ids'][0] diff --git a/sphinx/transforms.py b/sphinx/transforms.py index 7624ad170..72917f53f 100644 --- a/sphinx/transforms.py +++ b/sphinx/transforms.py @@ -109,11 +109,7 @@ class AutoNumbering(Transform): def apply(self): def has_child(node, cls): - for child in node: - if isinstance(child, cls): - return True - - return False + return any(isinstance(child, cls) for child in node) for node in self.document.traverse(nodes.Element): if isinstance(node, nodes.figure):