IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary check for type bytes

Browse Source 
On Python 3, the __file__ attribute is always a string. See docs:

https://docs.python.org/3/reference/import.html#__file__

> __file__ is optional. If set, this attribute’s value must be a string.
This commit is contained in:
Jon Dufresne 2018-12-15 11:02:06 -08:00
parent 6113261948
commit cc86f57f7f
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sphinx/util/__init__.py
View File

@ -36,7 +36,6 @@ from sphinx.locale import __
from sphinx.util import logging from sphinx.util import logging
from sphinx.util.console import strip_colors, colorize, bold, term_width_line # type: ignore from sphinx.util.console import strip_colors, colorize, bold, term_width_line # type: ignore
from sphinx.util.fileutil import copy_asset_file from sphinx.util.fileutil import copy_asset_file
from sphinx.util.osutil import fs_encoding
from sphinx.util import smartypants # noqa from sphinx.util import smartypants # noqa
# import other utilities; partly for backwards compatibility, so don't # import other utilities; partly for backwards compatibility, so don't
@ -270,8 +269,6 @@ def save_traceback(app):
if app is not None: if app is not None:
for ext in app.extensions.values(): for ext in app.extensions.values():
modfile = getattr(ext.module, '__file__', 'unknown') modfile = getattr(ext.module, '__file__', 'unknown')
if isinstance(modfile, bytes):
modfile = modfile.decode(fs_encoding, 'replace')
if ext.version != 'builtin': if ext.version != 'builtin':
os.write(fd, ('# %s (%s) from %s\n' % os.write(fd, ('# %s (%s) from %s\n' %
(ext.name, ext.version, modfile)).encode('utf-8')) (ext.name, ext.version, modfile)).encode('utf-8'))