From ea0fbd21d5e0c498cf13e338a1ed3dd64d15d4f3 Mon Sep 17 00:00:00 2001 From: Peter Bell Date: Wed, 15 Jul 2020 17:28:34 +0100 Subject: [PATCH] Add type check to aliases dict --- sphinx/deprecation.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sphinx/deprecation.py b/sphinx/deprecation.py index 9d67de9ca..5baac8cf5 100644 --- a/sphinx/deprecation.py +++ b/sphinx/deprecation.py @@ -40,6 +40,10 @@ class _ModuleWrapperDeprecatedAlias: def __init__(self, module: Any, modname: str, aliases: Dict[str, Tuple[str, object]], warning: "Type[Warning]") -> None: + if not all(isinstance(v, tuple) for v in aliases.values()): + raise TypeError('deprecated_alias expects aliases to be a dict mapping: ' + 'name -> tuple[canonical name, object]') + self._module = module self._modname = modname self._aliases = aliases