From f5d52fa4f454db08b6acb661748d1811770a959e Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Sun, 18 Apr 2010 09:55:38 +0200 Subject: [PATCH] #377: Fix crash in linkcheck builder if all parent nodes have no line number set. --- CHANGES | 2 ++ sphinx/builders/linkcheck.py | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index d64a1f712..c9275c720 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,8 @@ Release 0.6.6 (in development) ============================== +* #377: Fix crash in linkcheck builder. + * #387: Fix the display of search results in ``dirhtml`` output. * #376: In autodoc, fix display of parameter defaults containing diff --git a/sphinx/builders/linkcheck.py b/sphinx/builders/linkcheck.py index 300a13a10..1fead717a 100644 --- a/sphinx/builders/linkcheck.py +++ b/sphinx/builders/linkcheck.py @@ -65,8 +65,10 @@ class CheckExternalLinksBuilder(Builder): return lineno = None - while lineno is None and node: + while lineno is None: node = node.parent + if node is None: + break lineno = node.line if uri[0:5] == 'http:' or uri[0:6] == 'https:':