From 1ba882cf8788e8fdba1295476f0a5a16143f353f Mon Sep 17 00:00:00 2001 From: David Fischer Date: Mon, 14 May 2018 15:30:52 -0400 Subject: [PATCH 1/2] Accessibility improvements to the left nav --- docs/changelog.rst | 8 ++++++++ sass/_theme_layout.sass | 5 ++++- sass/_theme_variables.sass | 4 ++-- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 57af405b..c4b8e64f 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -3,6 +3,14 @@ Changelog ********* +Master +====== + +Fixes +----- + +* Color accessibility improvements on the left navigation + v0.3.1 ====== diff --git a/sass/_theme_layout.sass b/sass/_theme_layout.sass index a4c86caa..2aa40b52 100644 --- a/sass/_theme_layout.sass +++ b/sass/_theme_layout.sass @@ -24,7 +24,9 @@ padding: 0 $base-font-size .wy-menu-vertical + color: $menu-medium width: $nav-desktop-width + header, p.caption height: $base-font-size * 2 display: inline-block @@ -35,7 +37,6 @@ font-weight: bold text-transform: uppercase font-size: 80% - color: $menu-dark white-space: nowrap ul @@ -97,6 +98,8 @@ border-top: solid 1px darken($menu-vertical-background-color, 20%) // This is the on state for pages beyond second level + li.toctree-l2 a, li.toctree-l3 a, li.toctree-l4 a + color: $menu-link-color li.toctree-l1.current li.toctree-l2, li.toctree-l2.current li.toctree-l3 > ul display: none diff --git a/sass/_theme_variables.sass b/sass/_theme_variables.sass index 79630b41..dd9e30ff 100644 --- a/sass/_theme_variables.sass +++ b/sass/_theme_variables.sass @@ -32,7 +32,7 @@ $menu-vertical-background-color: $section-background-color // Menu text colors $menu-color: $gray $menu-dark: lighten($menu-color,10%) !default -$menu-medium: lighten($menu-color,25%) !default +$menu-medium: lighten($menu-color,30%) !default $menu-light: lighten($menu-color,45%) !default $menu-lighter: lighten($menu-color,60%) !default @@ -40,7 +40,7 @@ $menu-lighter: lighten($menu-color,60%) !default $menu-link-color: $text-color $menu-link-dark: $text-dark $menu-link-medium: $text-medium -$menu-link-light: $text-light +$menu-link-light: $text-lighter $menu-link-active: $white // Navigation colors From 0bd591e20c8070af0c0ff012f5a31fd76878b874 Mon Sep 17 00:00:00 2001 From: David Fischer Date: Tue, 15 May 2018 09:19:53 -0700 Subject: [PATCH 2/2] Slightly darken the left nav captions --- sass/_theme_layout.sass | 2 +- sass/_theme_variables.sass | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sass/_theme_layout.sass b/sass/_theme_layout.sass index 2aa40b52..2162143c 100644 --- a/sass/_theme_layout.sass +++ b/sass/_theme_layout.sass @@ -24,7 +24,6 @@ padding: 0 $base-font-size .wy-menu-vertical - color: $menu-medium width: $nav-desktop-width header, p.caption @@ -264,6 +263,7 @@ overflow-x: hidden overflow-y: hidden min-height: 100% + color: $menu-medium background: $nav-background-color z-index: $z-index-popover diff --git a/sass/_theme_variables.sass b/sass/_theme_variables.sass index dd9e30ff..b05a6a5f 100644 --- a/sass/_theme_variables.sass +++ b/sass/_theme_variables.sass @@ -32,7 +32,7 @@ $menu-vertical-background-color: $section-background-color // Menu text colors $menu-color: $gray $menu-dark: lighten($menu-color,10%) !default -$menu-medium: lighten($menu-color,30%) !default +$menu-medium: lighten($menu-color,27.5%) !default $menu-light: lighten($menu-color,45%) !default $menu-lighter: lighten($menu-color,60%) !default