NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

security: avoid memory leak

Browse Source 
Leak introduced in commit d6623003.

* src/qemu/qemu_driver.c (qemuSecurityInit): Avoid leak on failure.
* src/security/security_stack.c (virSecurityStackClose): Avoid
leaking component drivers.
This commit is contained in:
Eric Blake
2011-02-21 15:05:24 -07:00
parent dfd39ccda8
commit 009fce98be
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_driver.c
View File

@@ -204,8 +204,11 @@ qemuSecurityInit(struct qemud_driver *driver)
goto error; goto error;
if (!(driver->securityManager = virSecurityManagerNewStack(mgr, if (!(driver->securityManager = virSecurityManagerNewStack(mgr,
dac))) dac))) {
virSecurityManagerFree(dac);
goto error; goto error;
}
} else { } else {
driver->securityManager = mgr; driver->securityManager = mgr;
} }

7
src/security/security_stack.c
View File

@@ -61,8 +61,13 @@ virSecurityStackOpen(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
} }
static int static int
virSecurityStackClose(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED) virSecurityStackClose(virSecurityManagerPtr mgr)
{ {
virSecurityStackDataPtr priv = virSecurityManagerGetPrivateData(mgr);
virSecurityManagerFree(priv->primary);
virSecurityManagerFree(priv->secondary);
return 0; return 0;
} }