From 01b2f93df8fbad9fe1a7e02655bfec21851f63d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio@redhat.com>
Date: Thu, 19 Dec 2019 10:18:31 +0100
Subject: [PATCH] secret: Don't check the output of
 virGetUserRuntimeDirectory()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/secret/secret_driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
index cdc4b7dcf9..096672f114 100644
--- a/src/secret/secret_driver.c
+++ b/src/secret/secret_driver.c
@@ -478,8 +478,7 @@ secretStateInitialize(bool privileged,
         cfgdir = virGetUserConfigDirectory();
         driver->configDir = g_strdup_printf("%s/secrets/", cfgdir);
 
-        if (!(rundir = virGetUserRuntimeDirectory()))
-            goto error;
+        rundir = virGetUserRuntimeDirectory();
         driver->stateDir = g_strdup_printf("%s/secrets/run", rundir);
     }