NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID call

Browse Source 
Also a typo is fixed (s/detached/attached/)

Signed-off-by: Maxim Nestratov mnestratov@parallels.com
This commit is contained in:
Maxim Nestratov 2015-04-22 18:25:50 +03:00 committed by Michal Privoznik
parent e34cccf783
commit 0898d818ee
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/parallels/parallels_driver.c
View File

@ -1109,7 +1109,7 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid); privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid);
if (privdom == NULL) { if (privdom == NULL) {
parallelsDomNotFoundError(dom); parallelsDomNotFoundError(dom);
goto cleanup; return -1;
} }
if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) { if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) {
@ -1148,13 +1148,14 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
break; break;
default: default:
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
_("device type '%s' cannot be detached"), _("device type '%s' cannot be attached"),
virDomainDeviceTypeToString(dev->type)); virDomainDeviceTypeToString(dev->type));
break; break;
} }
ret = 0; ret = 0;
cleanup: cleanup:
virObjectUnlock(privdom);
return ret; return ret;
} }