From 0a41733c13cadafc3ad90d57b8a8cc3c462e7e9d Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Thu, 2 Jun 2011 16:38:38 -0600 Subject: [PATCH] lock: avoid leak on failure Detected by Coverity. Only possible on OOM situations. * src/locking/lock_manager.c (virLockManagerPluginNew): Plug leak. --- src/locking/lock_manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c index 6197fd404e..138cc91997 100644 --- a/src/locking/lock_manager.c +++ b/src/locking/lock_manager.c @@ -120,7 +120,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name, { void *handle = NULL; virLockDriverPtr driver; - virLockManagerPluginPtr plugin; + virLockManagerPluginPtr plugin = NULL; const char *moddir = getenv("LIBVIRT_LOCK_MANAGER_PLUGIN_DIR"); char *modfile = NULL; @@ -182,6 +182,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name, return plugin; cleanup: + VIR_FREE(plugin); VIR_FREE(modfile); if (handle) dlclose(handle);