NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

tests: invert the return logic in storagepoolcapstest

Browse Source 
This way if the first test "full" fails we will run the second test as
well.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2019-03-06 19:14:16 +01:00
parent a59590c7eb
commit 0b5b221300
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/storagepoolcapstest.c
View File

@ -84,7 +84,7 @@ test_virStoragePoolCapsFormat(const void *opaque)
static int static int
mymain(void) mymain(void)
{ {
int ret = -1; int ret = 0;
virCapsPtr fullCaps = NULL; virCapsPtr fullCaps = NULL;
virCapsPtr fsCaps = NULL; virCapsPtr fsCaps = NULL;
@ -93,12 +93,14 @@ mymain(void)
struct test_virStoragePoolCapsFormatData data = \ struct test_virStoragePoolCapsFormatData data = \
{.filename = Filename, .driverCaps = DriverCaps }; \ {.filename = Filename, .driverCaps = DriverCaps }; \
if (virTestRun(Filename, test_virStoragePoolCapsFormat, &data) < 0) \ if (virTestRun(Filename, test_virStoragePoolCapsFormat, &data) < 0) \
goto cleanup; \ ret = -1; \
} while (0) } while (0)
if (!(fullCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false)) || if (!(fullCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false)) ||
!(fsCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false))) !(fsCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false))) {
ret = -1;
goto cleanup; goto cleanup;
}
test_virCapabilitiesAddFullStoragePool(fullCaps); test_virCapabilitiesAddFullStoragePool(fullCaps);
test_virCapabilitiesAddFSStoragePool(fsCaps); test_virCapabilitiesAddFSStoragePool(fsCaps);
@ -106,8 +108,6 @@ mymain(void)
DO_TEST("full", fullCaps); DO_TEST("full", fullCaps);
DO_TEST("fs", fsCaps); DO_TEST("fs", fsCaps);
ret = 0;
cleanup: cleanup:
virObjectUnref(fullCaps); virObjectUnref(fullCaps);
virObjectUnref(fsCaps); virObjectUnref(fsCaps);