NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-01-24 15:26:40 -06:00
Code Issues Packages Projects Releases Wiki Activity

vmx: Relax virtualHW.version check

Browse Source 
The original implementation of the VMX config parser assumed that the
virtualHW.version would have more influence on the content of the VMX
file than it actually seems to have. It started with accepting only
version 4. Additonal versions were added later without any additional
changes in the parser itself. This suggests that the influence of the
virtualHW.version on the content and format of the VMX file is small
or non-existent.

The parser worked without any changes across several virtualHW and
vSphere versions. So instead of adding new virtualHW.version values to
the parser as they come along, or adding an extra flag to allow unknown
virtualHW.version values just relax the check to require version 4 or
later.
This commit is contained in:
Matthias Bolte 2014-05-10 16:36:56 +02:00
parent 7c6fc3948e
commit 0e4370eddf
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/vmx/vmx.c
View File

@ -1316,12 +1316,10 @@ virVMXParseConfig(virVMXContext *ctx,
goto cleanup;
}
if (virtualHW_version != 4 && virtualHW_version != 7 &&
virtualHW_version != 8 && virtualHW_version != 9 &&
virtualHW_version != 10) {
if (virtualHW_version < 4) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Expecting VMX entry 'virtualHW.version' to be "
"4, 7, 8, 9 or 10 but found %lld"),
"4 or higher but found %lld"),
virtualHW_version);
goto cleanup;
}