From 1130fa3188f068351515a60fe1f5d2cb18d69e92 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 18 Jan 2013 09:30:40 -0500 Subject: [PATCH] parallels: Need to handle virJSONValueObjectGetString error --- src/parallels/parallels_driver.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index ea193af72d..1b47246167 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -513,10 +513,9 @@ parallelsGetNetInfo(virDomainNetDefPtr net, } net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP; - if (virJSONValueObjectHasKey(value, "state")) { - tmp = virJSONValueObjectGetString(value, "state"); - if STREQ(tmp, "disconnected") - net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN; + if ((tmp = virJSONValueObjectGetString(value, "state")) && + STREQ(tmp, "disconnected")) { + net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN; } return 0;