From 13f40898abbfb4d797d55571e92cab91736f4a72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Wed, 6 Nov 2024 13:15:26 +0100 Subject: [PATCH] qemu: chardev: avoid impossible overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the rare case where int and long long are not the same size, the multiplication of an int variable and an int constant might overflow. Cast the constant to long long to avoid this. Signed-off-by: Ján Tomko Fixes: baa4edfb79d5ee861a08b5ec11416c5c156d8cd2 Reviewed-by: Peter Krempa --- src/qemu/qemu_chardev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_chardev.c b/src/qemu/qemu_chardev.c index b6828b6752..6b29744975 100644 --- a/src/qemu/qemu_chardev.c +++ b/src/qemu/qemu_chardev.c @@ -247,7 +247,7 @@ qemuChardevGetBackendProps(const virDomainChrSourceDef *chr, if (reconnect != -1 && virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_RECONNECT_MILISECONDS)) { - reconnect_ms = reconnect * 1000; + reconnect_ms = reconnect * (long long) 1000; reconnect = -1; }