diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5e3c077034..969a6632b8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4037,26 +4037,39 @@ virDomainDefAddConsoleCompat(virDomainDefPtr def) def->consoles[0]->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL; } } else if (def->os.type == VIR_DOMAIN_OSTYPE_HVM && def->nserials > 0 && - def->serials[0]->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL && - def->serials[0]->targetType == VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA) { - /* Create a stub console to match the serial port. - * console[0] either does not exist - * or has a different type than SERIAL or NONE. - */ - virDomainChrDefPtr chr; - if (!(chr = virDomainChrDefNew(NULL))) - return -1; + def->serials[0]->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL) { - if (VIR_INSERT_ELEMENT(def->consoles, - 0, - def->nconsoles, - chr) < 0) { - virDomainChrDefFree(chr); - return -1; + switch ((virDomainChrSerialTargetType) def->serials[0]->targetType) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA: { + + /* Create a stub console to match the serial port. + * console[0] either does not exist + * or has a different type than SERIAL or NONE. + */ + virDomainChrDefPtr chr; + if (!(chr = virDomainChrDefNew(NULL))) + return -1; + + if (VIR_INSERT_ELEMENT(def->consoles, + 0, + def->nconsoles, + chr) < 0) { + virDomainChrDefFree(chr); + return -1; + } + + def->consoles[0]->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE; + def->consoles[0]->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL; + + break; } - def->consoles[0]->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE; - def->consoles[0]->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL; + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PCI: + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB: + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_LAST: + /* Nothing to do */ + break; + } } return 0; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 836e40e590..9c24ee6534 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10251,7 +10251,7 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, serial->info.alias); } } else { - switch (serial->targetType) { + switch ((virDomainChrSerialTargetType) serial->targetType) { case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB: if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_SERIAL)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -10290,6 +10290,11 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, goto error; } break; + + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_LAST: + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Invalid target type for serial device")); + goto error; } virBufferAsprintf(&cmd, "%s,chardev=char%s,id=%s",