NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

parallels: Avoid possible leak of "cpu" from parallelsBuildCapabilities

Browse Source 
4d06af97d3 introduced a possible memory
leak of the memory allocated into the "cpu" pointer in
parallelsBuildCapabilities in the case "nodeGetInfo()" would fail right
after the allocation. Rearrange the code to avoid the possibility of the
leak.

Found by Coverity.
This commit is contained in:
Peter Krempa 2014-06-09 09:36:30 +02:00
parent df01390afc
commit 20d0c33aee
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/parallels/parallels_driver.c
View File

@ -151,10 +151,10 @@ parallelsBuildCapabilities(void)
"parallels", NULL, NULL, 0, NULL) == NULL) "parallels", NULL, NULL, 0, NULL) == NULL)
goto error; goto error;
if (VIR_ALLOC(cpu) < 0) if (nodeGetInfo(&nodeinfo))
goto error; goto error;
if (nodeGetInfo(&nodeinfo)) if (VIR_ALLOC(cpu) < 0)
goto error; goto error;
cpu->arch = caps->host.arch; cpu->arch = caps->host.arch;