NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect path length check in sanlock lockspace setup

Browse Source 
The code for creating a sanlock lockspace accidentally used
SANLK_NAME_LEN instead of SANLK_PATH_LEN for a size check.
This meant disk paths were limited to 48 bytes !

* src/locking/lock_driver_sanlock.c: Fix disk path length
  check
This commit is contained in:
Daniel P. Berrange 2011-08-30 12:24:06 -04:00
parent 173015bec6
commit 2223b1f71f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/locking/lock_driver_sanlock.c
View File

@ -159,10 +159,10 @@ static int virLockManagerSanlockSetupLockspace(void)
memcpy(ls.name, VIR_LOCK_MANAGER_SANLOCK_AUTO_DISK_LOCKSPACE, SANLK_NAME_LEN); memcpy(ls.name, VIR_LOCK_MANAGER_SANLOCK_AUTO_DISK_LOCKSPACE, SANLK_NAME_LEN);
ls.host_id = 0; /* Doesn't matter for initialization */ ls.host_id = 0; /* Doesn't matter for initialization */
ls.flags = 0; ls.flags = 0;
if (!virStrcpy(ls.host_id_disk.path, path, SANLK_NAME_LEN)) { if (!virStrcpy(ls.host_id_disk.path, path, SANLK_PATH_LEN)) {
virLockError(VIR_ERR_INTERNAL_ERROR, virLockError(VIR_ERR_INTERNAL_ERROR,
_("Lockspace path '%s' exceeded %d characters"), _("Lockspace path '%s' exceeded %d characters"),
path, SANLK_NAME_LEN); path, SANLK_PATH_LEN);
goto error; goto error;
} }
ls.host_id_disk.offset = 0; ls.host_id_disk.offset = 0;