NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Make sure the rundir is accessible by the user

Browse Source 
otherwise the user might not have enough permissions to access the
socket if root's umask is 077.

http://bugs.debian.org/614210
This commit is contained in:
Guido Günther 2011-03-09 14:15:48 +01:00
parent 9189301426
commit 24bfa52e93
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
daemon/libvirtd.c
View File

@ -3277,16 +3277,20 @@ int main(int argc, char **argv) {
/* Ensure the rundir exists (on tmpfs on some systems) */ /* Ensure the rundir exists (on tmpfs on some systems) */
if (geteuid() == 0) { if (geteuid() == 0) {
const char *rundir = LOCALSTATEDIR "/run/libvirt"; const char *rundir = LOCALSTATEDIR "/run/libvirt";
mode_t old_umask;
old_umask = umask(022);
if (mkdir (rundir, 0755)) { if (mkdir (rundir, 0755)) {
if (errno != EEXIST) { if (errno != EEXIST) {
char ebuf[1024]; char ebuf[1024];
VIR_ERROR(_("unable to create rundir %s: %s"), rundir, VIR_ERROR(_("unable to create rundir %s: %s"), rundir,
virStrerror(errno, ebuf, sizeof(ebuf))); virStrerror(errno, ebuf, sizeof(ebuf)));
ret = VIR_DAEMON_ERR_RUNDIR; ret = VIR_DAEMON_ERR_RUNDIR;
umask(old_umask);
goto error; goto error;
} }
} }
umask(old_umask);
} }
/* Beyond this point, nothing should rely on using /* Beyond this point, nothing should rely on using