Report errors in virCapabilitiesFormatXML

So far, we only report an error if formatting the siblings bitmap
in NUMA topology fails.

Be consistent and always report error in virCapabilitiesFormatXML.

src/bhyve/bhyve_driver.c

@@ -150,10 +150,8 @@ bhyveConnectGetCapabilities(virConnectPtr conn)
         goto cleanup;
     }
 
-    if (!(xml = virCapabilitiesFormatXML(caps))) {
+    if (!(xml = virCapabilitiesFormatXML(caps)))
-        virReportOOMError();
         goto cleanup;
-    }
 
  cleanup:
     virObjectUnref(caps);

src/conf/capabilities.c

@@ -1025,10 +1025,8 @@ virCapabilitiesFormatXML(virCapsPtr caps)
     virBufferAdjustIndent(&buf, -2);
     virBufferAddLit(&buf, "</capabilities>\n");
 
-    if (virBufferError(&buf)) {
+    if (virBufferCheckError(&buf) < 0)
-        virBufferFreeAndReset(&buf);
         return NULL;
-    }
 
     return virBufferContentAndReset(&buf);
 }

src/esx/esx_driver.c

@@ -1420,14 +1420,8 @@ static char *
 esxConnectGetCapabilities(virConnectPtr conn)
 {
     esxPrivate *priv = conn->privateData;
-    char *xml = virCapabilitiesFormatXML(priv->caps);
 
-    if (!xml) {
+    return virCapabilitiesFormatXML(priv->caps);
-        virReportOOMError();
-        return NULL;
-    }
-
-    return xml;
 }
 
 

src/libxl/libxl_driver.c

@@ -594,8 +594,7 @@ libxlConnectGetCapabilities(virConnectPtr conn)
         return NULL;
 
     cfg = libxlDriverConfigGet(driver);
-    if ((xml = virCapabilitiesFormatXML(cfg->caps)) == NULL)
+    xml = virCapabilitiesFormatXML(cfg->caps);
-        virReportOOMError();
 
     virObjectUnref(cfg);
     return xml;

src/lxc/lxc_driver.c

@@ -232,8 +232,7 @@ static char *lxcConnectGetCapabilities(virConnectPtr conn) {
     if (!(caps = virLXCDriverGetCapabilities(driver, false)))
         return NULL;
 
-    if ((xml = virCapabilitiesFormatXML(caps)) == NULL)
+    xml = virCapabilitiesFormatXML(caps);
-        virReportOOMError();
 
     virObjectUnref(caps);
     return xml;

src/parallels/parallels_driver.c

@@ -186,8 +186,7 @@ parallelsConnectGetCapabilities(virConnectPtr conn)
     char *xml;
 
     parallelsDriverLock(privconn);
-    if ((xml = virCapabilitiesFormatXML(privconn->caps)) == NULL)
+    xml = virCapabilitiesFormatXML(privconn->caps);
-        virReportOOMError();
     parallelsDriverUnlock(privconn);
     return xml;
 }

src/phyp/phyp_driver.c

@@ -3582,12 +3582,8 @@ static char *
 phypConnectGetCapabilities(virConnectPtr conn)
 {
     phyp_driverPtr phyp_driver = conn->privateData;
-    char *xml;
 
-    if ((xml = virCapabilitiesFormatXML(phyp_driver->caps)) == NULL)
+    return virCapabilitiesFormatXML(phyp_driver->caps);
-        virReportOOMError();
-
-    return xml;
 }
 
 static int

src/qemu/qemu_driver.c

@@ -1245,8 +1245,7 @@ static char *qemuConnectGetCapabilities(virConnectPtr conn) {
     if (!(caps = virQEMUDriverGetCapabilities(driver, true)))
         goto cleanup;
 
-    if ((xml = virCapabilitiesFormatXML(caps)) == NULL)
+    xml = virCapabilitiesFormatXML(caps);
-        virReportOOMError();
     virObjectUnref(caps);
 
  cleanup:

src/test/test_driver.c

@@ -1677,8 +1677,7 @@ static char *testConnectGetCapabilities(virConnectPtr conn)
     testConnPtr privconn = conn->privateData;
     char *xml;
     testDriverLock(privconn);
-    if ((xml = virCapabilitiesFormatXML(privconn->caps)) == NULL)
+    xml = virCapabilitiesFormatXML(privconn->caps);
-        virReportOOMError();
     testDriverUnlock(privconn);
     return xml;
 }

src/uml/uml_driver.c

@@ -1310,8 +1310,7 @@ static char *umlConnectGetCapabilities(virConnectPtr conn) {
         return NULL;
 
     umlDriverLock(driver);
-    if ((xml = virCapabilitiesFormatXML(driver->caps)) == NULL)
+    xml = virCapabilitiesFormatXML(driver->caps);
-        virReportOOMError();
     umlDriverUnlock(driver);
 
     return xml;

src/xen/xen_driver.c

@@ -720,17 +720,11 @@ static char *
 xenUnifiedConnectGetCapabilities(virConnectPtr conn)
 {
     xenUnifiedPrivatePtr priv = conn->privateData;
-    char *xml;
 
     if (virConnectGetCapabilitiesEnsureACL(conn) < 0)
         return NULL;
 
-    if (!(xml = virCapabilitiesFormatXML(priv->caps))) {
+    return virCapabilitiesFormatXML(priv->caps);
-        virReportOOMError();
-        return NULL;
-    }
-
-    return xml;
 }
 
 static int

src/xen/xen_hypervisor.c

@@ -2557,14 +2557,8 @@ char *
 xenHypervisorGetCapabilities(virConnectPtr conn)
 {
     xenUnifiedPrivatePtr priv = conn->privateData;
-    char *xml;
 
-    if (!(xml = virCapabilitiesFormatXML(priv->caps))) {
+    return virCapabilitiesFormatXML(priv->caps);
-        virReportOOMError();
-        return NULL;
-    }
-
-    return xml;
 }
 
 

src/xenapi/xenapi_driver.c

@@ -445,12 +445,8 @@ xenapiConnectGetCapabilities(virConnectPtr conn)
 {
 
     virCapsPtr caps = ((struct _xenapiPrivate *)(conn->privateData))->caps;
-    if (caps) {
+    if (caps)
-        char *xml = virCapabilitiesFormatXML(caps);
+        return virCapabilitiesFormatXML(caps);
-        if (!xml)
-            goto cleanup;
-        return xml;
-    }
  cleanup:
     xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR,
                               _("Capabilities not available"));

tests/vircaps2xmltest.c

@@ -114,10 +114,8 @@ test_virCapabilitiesFormat(const void *opaque)
                                       data->max_mem_in_cell)))
         goto cleanup;
 
-    if (!(capsXML = virCapabilitiesFormatXML(caps))) {
+    if (!(capsXML = virCapabilitiesFormatXML(caps)))
-        fprintf(stderr, "Unable to format capabilities XML");
         goto cleanup;
-    }
 
     if (virAsprintf(&path, "%s/vircaps2xmldata/vircaps-%s.xml",
                     abs_srcdir, data->filename) < 0)