NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

build: force configure failed when perl is missing

Browse Source 
Perl is necessary to our build processing, it will invoke a lot of
generating script, like: gendispatch.pl. If perl is missing, it's
ok for build from git checkout, because autogen.sh will tell you.
But for compiling from a release tarball, configure will just record
a missing message, and continue, then build failed, like:
https://www.redhat.com/archives/libvirt-users/2014-August/msg00050.html

So need to enhance configure script to handle this negative case.

Reported-by: Hongbin Lu <hongbin@savinetwork.ca>
Signed-off-by: Jincheng Miao <jmiao@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Jincheng Miao 2014-08-14 11:37:45 +08:00 committed by Michal Privoznik
parent ca8ef1df3b
commit 3f03398dbe
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure.ac
View File

@ -2173,6 +2173,9 @@ AM_CONDITIONAL([WITH_HYPERV], [test "$with_hyperv" = "yes"])
dnl Allow perl/python overrides dnl Allow perl/python overrides
AC_PATH_PROGS([PYTHON], [python2 python]) AC_PATH_PROGS([PYTHON], [python2 python])
AC_PATH_PROG([PERL], [perl]) AC_PATH_PROG([PERL], [perl])
if test -z "$PERL"; then
AC_MSG_ERROR([Failed to find perl.])
fi
AC_ARG_WITH([test-suite], AC_ARG_WITH([test-suite],
[AS_HELP_STRING([--with-test-suite], [AS_HELP_STRING([--with-test-suite],

1
libvirt.spec.in
View File

@ -446,6 +446,7 @@ BuildRequires: gettext-devel
BuildRequires: libtool BuildRequires: libtool
BuildRequires: /usr/bin/pod2man BuildRequires: /usr/bin/pod2man
%endif %endif
BuildRequires: perl
BuildRequires: python BuildRequires: python
%if %{with_systemd} %if %{with_systemd}
BuildRequires: systemd-units BuildRequires: systemd-units