diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 9eeed8a86d..bc2fdfbaa0 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1337,7 +1337,7 @@ qemuDomainObjPrivateXMLFormatVcpus(virBufferPtr buf,
virBufferAdjustIndent(buf, 2);
for (i = 0; i < nvcpupids; i++)
- virBufferAsprintf(buf, "\n", vcpupids[i]);
+ virBufferAsprintf(buf, "\n", i, vcpupids[i]);
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "\n");
@@ -1466,9 +1466,19 @@ qemuDomainObjPrivateXMLParseVcpu(xmlNodePtr node,
unsigned int idx,
qemuDomainObjPrivatePtr priv)
{
+ char *idstr;
char *pidstr;
int ret = -1;
+ if ((idstr = virXMLPropString(node, "id"))) {
+ if (virStrToLong_uip(idstr, NULL, 10, &idx) < 0 ||
+ idx >= priv->nvcpupids) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("invalid vcpu index '%s'"), idstr);
+ goto cleanup;
+ }
+ }
+
if (!(pidstr = virXMLPropString(node, "pid")))
goto cleanup;
@@ -1478,6 +1488,7 @@ qemuDomainObjPrivateXMLParseVcpu(xmlNodePtr node,
ret = 0;
cleanup:
+ VIR_FREE(idstr);
VIR_FREE(pidstr);
return ret;
}
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index eb392f4863..eb810e3ce4 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -113,7 +113,8 @@ testGetStatuXMLPrefixVcpus(virBufferPtr buf,
virBufferAdjustIndent(buf, 2);
while ((vcpuid = virBitmapNextSetBit(data->activeVcpus, vcpuid)) >= 0)
- virBufferAsprintf(buf, "\n", vcpuid + 3803519);
+ virBufferAsprintf(buf, "\n",
+ vcpuid, vcpuid + 3803519);
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "\n");