From 4114fb27125c23610f152b4be4e7cc5c9aef1a6d Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Tue, 23 Feb 2021 17:54:56 +0100 Subject: [PATCH] util: Simplify stubs Calling a stub should always result in ENOSYS being raised, regardless of what arguments are passed to it. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/util/virprocess.c | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 55c46a0bad..77eeab6a06 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -789,11 +789,9 @@ virProcessSetMaxMemLock(pid_t pid, unsigned long long bytes) } #else /* ! (WITH_SETRLIMIT && defined(RLIMIT_MEMLOCK)) */ int -virProcessSetMaxMemLock(pid_t pid G_GNUC_UNUSED, unsigned long long bytes) +virProcessSetMaxMemLock(pid_t pid G_GNUC_UNUSED, + unsigned long long bytes G_GNUC_UNUSED) { - if (bytes == 0) - return 0; - virReportSystemError(ENOSYS, "%s", _("Not supported on this platform")); return -1; } @@ -850,11 +848,8 @@ virProcessGetMaxMemLock(pid_t pid, #else /* ! (WITH_GETRLIMIT && defined(RLIMIT_MEMLOCK)) */ int virProcessGetMaxMemLock(pid_t pid G_GNUC_UNUSED, - unsigned long long *bytes) + unsigned long long *bytes G_GNUC_UNUSED) { - if (!bytes) - return 0; - virReportSystemError(ENOSYS, "%s", _("Not supported on this platform")); return -1; } @@ -900,11 +895,9 @@ virProcessSetMaxProcesses(pid_t pid, unsigned int procs) } #else /* ! (WITH_SETRLIMIT && defined(RLIMIT_NPROC)) */ int -virProcessSetMaxProcesses(pid_t pid G_GNUC_UNUSED, unsigned int procs) +virProcessSetMaxProcesses(pid_t pid G_GNUC_UNUSED, + unsigned int procs G_GNUC_UNUSED) { - if (procs == 0) - return 0; - virReportSystemError(ENOSYS, "%s", _("Not supported on this platform")); return -1; } @@ -957,11 +950,9 @@ virProcessSetMaxFiles(pid_t pid, unsigned int files) } #else /* ! (WITH_SETRLIMIT && defined(RLIMIT_NOFILE)) */ int -virProcessSetMaxFiles(pid_t pid G_GNUC_UNUSED, unsigned int files) +virProcessSetMaxFiles(pid_t pid G_GNUC_UNUSED, + unsigned int files G_GNUC_UNUSED) { - if (files == 0) - return 0; - virReportSystemError(ENOSYS, "%s", _("Not supported on this platform")); return -1; } @@ -1004,11 +995,8 @@ virProcessSetMaxCoreSize(pid_t pid, unsigned long long bytes) #else /* ! (WITH_SETRLIMIT && defined(RLIMIT_CORE)) */ int virProcessSetMaxCoreSize(pid_t pid G_GNUC_UNUSED, - unsigned long long bytes) + unsigned long long bytes G_GNUC_UNUSED) { - if (bytes == 0) - return 0; - virReportSystemError(ENOSYS, "%s", _("Not supported on this platform")); return -1; }