From 462863a3eeda479bf564bf672be6e2546900d26f Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Tue, 30 Jul 2013 16:04:48 +0200 Subject: [PATCH] spec: Don't mix commands with macro definitions %build section should first define all required macros and then run commands. Interleaving them makes it harder to spot what commands are run. --- libvirt.spec.in | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 156146296e..fce7f9126d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1343,10 +1343,6 @@ of recent versions of Linux (and other OSes). %define init_scripts --with-init_script=redhat %endif -%if 0%{?enable_autotools} - autoreconf -if -%endif - %if %{with_selinux} %if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 %define with_selinux_mount --with-selinux-mount="/sys/fs/selinux" @@ -1355,6 +1351,12 @@ of recent versions of Linux (and other OSes). %endif %endif +# place macros above and build commands below this comment + +%if 0%{?enable_autotools} + autoreconf -if +%endif + %configure %{?_without_xen} \ %{?_without_qemu} \ %{?_without_openvz} \