NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

remote: DeserializeDomainDiskErrors: remove dead code

Browse Source 
As of commit b2d079c113 which converted this function to use g_strdup,
the error label is only reached when i = 0, rendering it useless.

Remove it.

Fixes: https://gitlab.com/libvirt/libvirt/-/issues/572
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Ján Tomko 2023-12-19 16:46:53 +01:00
parent 405f479d0e
commit 49f1406de8
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/remote/remote_driver.c
View File

@ -1641,12 +1641,11 @@ remoteDeserializeDomainDiskErrors(remote_domain_disk_error *ret_errors_val,
int maxerrors) int maxerrors)
{ {
size_t i = 0; size_t i = 0;
size_t j;
if (ret_errors_len > limit || ret_errors_len > maxerrors) { if (ret_errors_len > limit || ret_errors_len > maxerrors) {
virReportError(VIR_ERR_RPC, "%s", virReportError(VIR_ERR_RPC, "%s",
_("returned number of disk errors exceeds limit")); _("returned number of disk errors exceeds limit"));
goto error; return -1;
} }
for (i = 0; i < ret_errors_len; i++) { for (i = 0; i < ret_errors_len; i++) {
@ -1655,12 +1654,6 @@ remoteDeserializeDomainDiskErrors(remote_domain_disk_error *ret_errors_val,
} }
return 0; return 0;
error:
for (j = 0; j < i; j++)
VIR_FREE(errors[j].disk);
return -1;
} }
static int static int