conf: don't use passed in caps in post parse method

To enable the virCapsPtr parameter to the post parse method to be
eliminated, the drivers must fetch the virCapsPtr from their own
driver via the opaque parameter, or use an alternative approach
to validate the parsed data.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé
2019-12-03 10:49:49 +00:00
parent 2578d74aee
commit 4a4132b462
35 changed files with 301 additions and 144 deletions

View File

@@ -6,7 +6,9 @@
#include "testutilshostcpus.h"
#include "domain_conf.h"
virCapsPtr
#define VIR_FROM_THIS VIR_FROM_LIBXL
static virCapsPtr
testXLInitCaps(void)
{
virCapsPtr caps;
@@ -79,3 +81,33 @@ testXLInitCaps(void)
virObjectUnref(caps);
return NULL;
}
libxlDriverPrivatePtr testXLInitDriver(void)
{
libxlDriverPrivatePtr driver = g_new0(libxlDriverPrivate, 1);
if (virMutexInit(&driver->lock) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
"%s", "cannot initialize mutex");
g_free(driver);
return NULL;
}
driver->config = libxlDriverConfigNew();
driver->config->caps = testXLInitCaps();
driver->xmlopt = libxlCreateXMLConf(driver);
return driver;
}
void testXLFreeDriver(libxlDriverPrivatePtr driver)
{
virObjectUnref(driver->config->caps);
virObjectUnref(driver->config);
virObjectUnref(driver->xmlopt);
virMutexDestroy(&driver->lock);
g_free(driver);
}