mirror of
https://github.com/libvirt/libvirt.git
synced 2025-02-25 18:55:26 -06:00
ci: Avoid use of magic constants
The value 3 is the length of the "ci-" prefix, which is present in the items returned by get_registry_images() but not in those returned by get_dockerfiles(). Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Beraldo Leal <bleal@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
@@ -68,10 +68,11 @@ def get_registry_stale_images(registry_uri: str, base_dir: str) -> Dict[str, int
|
|||||||
|
|
||||||
dockerfiles = get_dockerfiles(base_dir)
|
dockerfiles = get_dockerfiles(base_dir)
|
||||||
images = get_registry_images(registry_uri)
|
images = get_registry_images(registry_uri)
|
||||||
|
name_prefix = "ci-"
|
||||||
|
|
||||||
stale_images = {}
|
stale_images = {}
|
||||||
for img in images:
|
for img in images:
|
||||||
if img["name"][3:] not in dockerfiles:
|
if img["name"][len(name_prefix):] not in dockerfiles:
|
||||||
stale_images[img["name"]] = img["id"]
|
stale_images[img["name"]] = img["id"]
|
||||||
|
|
||||||
return stale_images
|
return stale_images
|
||||||
|
|||||||
Reference in New Issue
Block a user