NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Fix possible NULL deref in qemuDomainGetResctrlMonData

Browse Source 
If virQEMUDriverGetCapabilities returns NULL, then a subsequent
deref of @caps would cause an error, so we just return failure.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
John Ferlan 2019-08-07 09:54:06 -04:00
parent a067b781e9
commit 4e02d52ab9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_driver.c
View File

@ -20728,7 +20728,8 @@ qemuDomainGetResctrlMonData(virQEMUDriverPtr driver,
size_t i = 0; size_t i = 0;
size_t j = 0; size_t j = 0;
caps = virQEMUDriverGetCapabilities(driver, false); if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
return -1;
switch (tag) { switch (tag) {
case VIR_RESCTRL_MONITOR_TYPE_CACHE: case VIR_RESCTRL_MONITOR_TYPE_CACHE: