NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory

Browse Source 
Attributes are mandatory and were incorrectly made optional recently.

Fixes: 2a5e16398e
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Tim Wiederhake 2021-05-05 12:55:47 +02:00 committed by Michal Privoznik
parent 4647ac4205
commit 4ecf7ff393
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/domain_conf.c
View File

@ -12739,12 +12739,12 @@ virDomainGraphicsDefParseXMLSpice(virDomainGraphicsDef *def,
if (virXMLPropEnum(node_list[i], "name", if (virXMLPropEnum(node_list[i], "name",
virDomainGraphicsSpiceChannelNameTypeFromString, virDomainGraphicsSpiceChannelNameTypeFromString,
VIR_XML_PROP_NONE, &name) < 0) VIR_XML_PROP_REQUIRED, &name) < 0)
return -1; return -1;
if (virXMLPropEnum(node_list[i], "mode", if (virXMLPropEnum(node_list[i], "mode",
virDomainGraphicsSpiceChannelModeTypeFromString, virDomainGraphicsSpiceChannelModeTypeFromString,
VIR_XML_PROP_NONE, &mode) < 0) VIR_XML_PROP_REQUIRED, &mode) < 0)
return -1; return -1;
def->data.spice.channels[name] = mode; def->data.spice.channels[name] = mode;