From 53fe17bb23ca6723dbaacf849bff8461a474d07a Mon Sep 17 00:00:00 2001 From: Anastasia Belova Date: Thu, 28 Sep 2023 14:55:11 +0300 Subject: [PATCH] qemu: Add VIR_FREE in ADD_BITMAP virBitmapFormat returns the string that should be freed. All strings in three ADD_BITMAP calls in qemuDomainGetGuestVcpusParams are contained in tmp. So memory leak is possible here without VIR_FREE. Fixes: 0108deb944af5ca6f1da350c9d0352c8ed18738b Signed-off-by: Anastasia Belova Signed-off-by: Michal Privoznik Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9e0f204e44..056b5cec98 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18420,6 +18420,7 @@ qemuDomainGetGuestVcpusParams(virTypedParameterPtr *params, goto cleanup; \ if (virTypedParamsAddString(&par, &npar, &maxpar, #name, tmp) < 0) \ goto cleanup; \ + VIR_FREE(tmp) ADD_BITMAP(vcpus); ADD_BITMAP(online);